diff options
| author | Alex Williams <alex.williams@ni.com> | 2019-12-12 10:29:11 -0800 |
|---|---|---|
| committer | Brent Stapleton <brent.stapleton@ettus.com> | 2019-12-20 16:32:22 -0800 |
| commit | 691f191a1ea1a8d655976c9f7b9fdfe7b4b36a41 (patch) | |
| tree | cfa48579158488852d8a7832da1cda14d7904373 /host/lib/usrp/x300/x300_mb_iface.cpp | |
| parent | cb400696bf2fbe82eea0f38d04a1771ccf6fd868 (diff) | |
| download | uhd-691f191a1ea1a8d655976c9f7b9fdfe7b4b36a41.tar.gz uhd-691f191a1ea1a8d655976c9f7b9fdfe7b4b36a41.tar.bz2 uhd-691f191a1ea1a8d655976c9f7b9fdfe7b4b36a41.zip | |
transport,usrp: Make available packet-based flow control
DPDK provides a fixed number of fixed-size buffers for the receive
window, so it needs packet-based flow control to avoid dropping
packets. This change enables counting by packets.
Co-authored-by: Ciro Nishiguchi <ciro.nishiguchi@ni.com>
Diffstat (limited to 'host/lib/usrp/x300/x300_mb_iface.cpp')
| -rw-r--r-- | host/lib/usrp/x300/x300_mb_iface.cpp | 27 |
1 files changed, 16 insertions, 11 deletions
diff --git a/host/lib/usrp/x300/x300_mb_iface.cpp b/host/lib/usrp/x300/x300_mb_iface.cpp index e0c426138..412b28a92 100644 --- a/host/lib/usrp/x300/x300_mb_iface.cpp +++ b/host/lib/usrp/x300/x300_mb_iface.cpp @@ -98,7 +98,7 @@ uhd::rfnoc::chdr_ctrl_xport::sptr x300_impl::x300_mb_iface::make_ctrl_transport( send_link_if::sptr send_link; recv_link_if::sptr recv_link; bool lossy_xport; - std::tie(send_link, std::ignore, recv_link, std::ignore, lossy_xport) = + std::tie(send_link, std::ignore, recv_link, std::ignore, lossy_xport, std::ignore) = _conn_mgr->get_links(link_type_t::CTRL, local_device_id, local_epid, @@ -139,8 +139,8 @@ uhd::rfnoc::chdr_rx_data_xport::uptr x300_impl::x300_mb_iface::make_rx_data_tran send_link_if::sptr send_link; recv_link_if::sptr recv_link; size_t recv_buff_size; - bool lossy_xport; - std::tie(send_link, std::ignore, recv_link, recv_buff_size, lossy_xport) = + bool lossy_xport, packet_fc; + std::tie(send_link, std::ignore, recv_link, recv_buff_size, lossy_xport, packet_fc) = _conn_mgr->get_links(link_type_t::RX_DATA, local_sep_addr.first, local_epid, @@ -150,16 +150,21 @@ uhd::rfnoc::chdr_rx_data_xport::uptr x300_impl::x300_mb_iface::make_rx_data_tran /* Associate local device ID with the adapter */ _adapter_map[local_sep_addr.first] = send_link->get_send_adapter_id(); - // TODO: configure this based on the transport type - const uhd::rfnoc::stream_buff_params_t recv_capacity = { - recv_buff_size, uhd::rfnoc::MAX_FC_CAPACITY_PKTS}; + const uhd::rfnoc::stream_buff_params_t recv_capacity = {recv_buff_size, + packet_fc ? static_cast<uint32_t>(recv_link->get_num_recv_frames()) + : uhd::rfnoc::MAX_FC_CAPACITY_PKTS}; const double ratio = 1.0 / 32; - // Configure flow control frequency to use bytes only for UDP - uhd::rfnoc::stream_buff_params_t fc_freq = { - static_cast<uint64_t>(std::ceil(double(recv_buff_size) * ratio)), - uhd::rfnoc::MAX_FC_FREQ_PKTS}; + // Configure flow control frequency to use either bytes only or packets only + uhd::rfnoc::stream_buff_params_t fc_freq; + if (packet_fc) { + fc_freq = {uhd::rfnoc::MAX_FC_FREQ_BYTES, + static_cast<uint32_t>(std::ceil(recv_link->get_num_recv_frames() * ratio))}; + } else { + fc_freq = {static_cast<uint64_t>(std::ceil(double(recv_buff_size) * ratio)), + uhd::rfnoc::MAX_FC_FREQ_PKTS}; + } uhd::rfnoc::stream_buff_params_t fc_headroom = {0, 0}; @@ -220,7 +225,7 @@ uhd::rfnoc::chdr_tx_data_xport::uptr x300_impl::x300_mb_iface::make_tx_data_tran send_link_if::sptr send_link; recv_link_if::sptr recv_link; bool lossy_xport; - std::tie(send_link, std::ignore, recv_link, std::ignore, lossy_xport) = + std::tie(send_link, std::ignore, recv_link, std::ignore, lossy_xport, std::ignore) = _conn_mgr->get_links(link_type_t::TX_DATA, local_sep_addr.first, local_epid, |