aboutsummaryrefslogtreecommitdiffstats
path: root/host/lib/include/uhdlib/transport/io_service.hpp
diff options
context:
space:
mode:
authorMartin Braun <martin.braun@ettus.com>2021-01-08 12:25:25 +0100
committerAaron Rossetto <aaron.rossetto@ni.com>2021-03-04 08:23:50 -0600
commit49e5ef81530684998bc4bc0934590cdaa81190ab (patch)
treea985c6e7864cb60a33e783910bcf2d072688d114 /host/lib/include/uhdlib/transport/io_service.hpp
parentdf6c2bebae7af7968165f6ad16e56d3f9fccef52 (diff)
downloaduhd-49e5ef81530684998bc4bc0934590cdaa81190ab.tar.gz
uhd-49e5ef81530684998bc4bc0934590cdaa81190ab.tar.bz2
uhd-49e5ef81530684998bc4bc0934590cdaa81190ab.zip
lib: Add some virtual dtors
Classes where we call delete (implicitly or explicitly) with a virtual inheritance structure need to declare dtors as virtual. This reduces compiler warnings with clang. There are no known bugs (yet) due to this.
Diffstat (limited to 'host/lib/include/uhdlib/transport/io_service.hpp')
-rw-r--r--host/lib/include/uhdlib/transport/io_service.hpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/host/lib/include/uhdlib/transport/io_service.hpp b/host/lib/include/uhdlib/transport/io_service.hpp
index 0cc2f86e3..c97ae49ea 100644
--- a/host/lib/include/uhdlib/transport/io_service.hpp
+++ b/host/lib/include/uhdlib/transport/io_service.hpp
@@ -104,6 +104,8 @@ class recv_io_if
public:
using sptr = std::shared_ptr<recv_io_if>;
+ virtual ~recv_io_if() = default;
+
/*!
* Callback for producing a flow control response (or any other response
* needed when a received frame_buff is released via
@@ -188,6 +190,8 @@ class send_io_if
public:
using sptr = std::shared_ptr<send_io_if>;
+ virtual ~send_io_if() = default;
+
/*!
* Callback for sending the packet. Callback should call release_send_buff()
* and update any internal state needed. For example, flow control state
@@ -366,6 +370,7 @@ public:
io_service() = default;
io_service(const io_service&) = delete;
io_service& operator=(const io_service&) = delete;
+ virtual ~io_service() = default;
};
}} // namespace uhd::transport