aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Storsjo <martin@martin.st>2017-06-22 11:52:08 +0300
committerMartin Storsjo <martin@martin.st>2017-06-22 11:54:29 +0300
commita9c8cb2cf64004a8d4089aef953734c6e98f7c52 (patch)
tree4196d1f1b997794df9f739cc6235f5c399ea62ad
parente7f36eed224b9530cf0eb7e56d6c43d3de14429e (diff)
downloadfdk-aac-a9c8cb2cf64004a8d4089aef953734c6e98f7c52.tar.gz
fdk-aac-a9c8cb2cf64004a8d4089aef953734c6e98f7c52.tar.bz2
fdk-aac-a9c8cb2cf64004a8d4089aef953734c6e98f7c52.zip
Revert "Fix "Stack-buffer-overflow in FDKmemset""
This reverts commit 39e13c1acbca94f562f9776e1555ced50dd0dfcd. This turned out to break HE-AACv2 encoding. Will look for a better fix for the issue found by the fuzzed sample. This fixes issue #69.
-rw-r--r--libFDK/src/qmf.cpp4
1 files changed, 0 insertions, 4 deletions
diff --git a/libFDK/src/qmf.cpp b/libFDK/src/qmf.cpp
index 13e6ff2..54526dd 100644
--- a/libFDK/src/qmf.cpp
+++ b/libFDK/src/qmf.cpp
@@ -791,10 +791,6 @@ qmfInverseModulationHQ( HANDLE_QMF_FILTER_BANK synQmf, /*!< Handle of Qmf Synth
scaleValues(&tImag[0+synQmf->lsb], &qmfImag[0+synQmf->lsb], synQmf->usb-synQmf->lsb, scaleFactorHighBand);
}
- if (synQmf->usb >= synQmf->no_channels) {
- return;
- }
-
FDKmemclear(&tReal[synQmf->usb], (synQmf->no_channels-synQmf->usb)*sizeof(FIXP_QMF));
FDKmemclear(&tImag[synQmf->usb], (synQmf->no_channels-synQmf->usb)*sizeof(FIXP_QMF));