aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFraunhofer IIS FDK <audio-fdk@iis.fraunhofer.de>2020-05-08 16:40:06 +0200
committerJean-Michel Trivi <jmtrivi@google.com>2021-04-29 19:12:14 +0000
commit5a83a8e5e1cafceba6bef7ac61e68a57cc93d786 (patch)
tree707b447f0954b10f9866c94f9097bbf31bf5007d
parent5f80d21a8a5ee31d7eb4b6d171223aa357fdf629 (diff)
downloadfdk-aac-5a83a8e5e1cafceba6bef7ac61e68a57cc93d786.tar.gz
fdk-aac-5a83a8e5e1cafceba6bef7ac61e68a57cc93d786.tar.bz2
fdk-aac-5a83a8e5e1cafceba6bef7ac61e68a57cc93d786.zip
Avoid signed integer overflow in pcmLimiter_Apply().
Bug: 186706541 Test: atest android.media.cts.DecoderTestAacFormat android.media.cts.DecoderTestXheAac android.media.cts.DecoderTestAacDrc Change-Id: I89f5206053926cb2f8726e4bc1ffb9fc88371edb
-rw-r--r--libPCMutils/src/limiter.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/libPCMutils/src/limiter.cpp b/libPCMutils/src/limiter.cpp
index 598dc0c..c6b8687 100644
--- a/libPCMutils/src/limiter.cpp
+++ b/libPCMutils/src/limiter.cpp
@@ -1,7 +1,7 @@
/* -----------------------------------------------------------------------------
Software License for The Fraunhofer FDK AAC Codec Library for Android
-© Copyright 1995 - 2019 Fraunhofer-Gesellschaft zur Förderung der angewandten
+© Copyright 1995 - 2020 Fraunhofer-Gesellschaft zur Förderung der angewandten
Forschung e.V. All rights reserved.
1. INTRODUCTION
@@ -322,7 +322,8 @@ TDLIMITER_ERROR pcmLimiter_Apply(TDLimiterPtr limiter, PCM_LIM* samplesIn,
(FIXP_DBL)SATURATE_LEFT_SHIFT(tmp, scaling, DFRACT_BITS));
#else
samplesOut[j] = (INT_PCM)FX_DBL2FX_PCM((FIXP_DBL)SATURATE_LEFT_SHIFT(
- tmp + ((FIXP_DBL)0x8000 >> scaling), scaling, DFRACT_BITS));
+ (tmp >> 1) + ((FIXP_DBL)0x8000 >> (scaling + 1)), scaling + 1,
+ DFRACT_BITS));
#endif
}
}