1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
|
/*
Copyright (C) 2007, 2008, 2009, 2010, 2011 Her Majesty the Queen in
Right of Canada (Communications Research Center Canada)
Written by
2012, Matthias P. Braendli, matthias.braendli@mpb.li
This block implements a FIR filter. The real filter taps are given
as floats, and the block can take advantage of SSE.
For better performance, filtering is done in another thread, leading
to a pipeline delay of two calls to FIRFilter::process
*/
/*
This file is part of ODR-DabMod.
ODR-DabMod is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as
published by the Free Software Foundation, either version 3 of the
License, or (at your option) any later version.
ODR-DabMod is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with ODR-DabMod. If not, see <http://www.gnu.org/licenses/>.
*/
#include "FIRFilter.h"
#include "PcDebug.h"
#include <stdio.h>
#include <stdexcept>
#include <iostream>
#include <fstream>
#include <boost/make_shared.hpp>
#ifdef __AVX__
# include <immintrin.h>
#else
# ifdef __SSE__
# include <xmmintrin.h>
# endif
#endif
using namespace std;
#include <sys/time.h>
void FIRFilterWorker::process(struct FIRFilterWorkerData *fwd)
{
size_t i;
struct timespec time_start;
struct timespec time_end;
// This thread creates the dataOut buffer, and deletes
// the incoming buffer
while(running) {
boost::shared_ptr<Buffer> dataIn;
fwd->input_queue.wait_and_pop(dataIn);
boost::shared_ptr<Buffer> dataOut = boost::make_shared<Buffer>();
dataOut->setLength(dataIn->getLength());
PDEBUG("FIRFilterWorker: dataIn->getLength() %zu\n", dataIn->getLength());
#if __AVX__
#define _mm256_load1_ps(x) _mm256_set_ps(x, x, x, x, x, x, x, x)
#warning FIRFilter uses experimental AVX code
// The AVX accelerated version cannot work on the complex values,
// it is necessary to do the convolution on the real and imaginary
// parts separately. Thankfully, the taps are real, simplifying the
// procedure.
//
// The AVX version is not enabled by default, because the performance
// on my test machine (sandy bridge i7) is slightly worse with AVX than
// with SSE. TODO: Try with Ivy Bridge or newer.
//
// Interesting links:
// http://software.intel.com/en-us/forums/topic/283753
const float* in = reinterpret_cast<const float*>(dataIn->getData());
float* out = reinterpret_cast<float*>(dataOut->getData());
size_t sizeIn = dataIn->getLength() / sizeof(float);
if ((uintptr_t)(&out[0]) % 32 != 0) {
fprintf(stderr, "FIRFilterWorker: out not aligned %p ", out);
throw std::runtime_error("FIRFilterWorker: out not aligned");
}
clock_gettime(CLOCK_THREAD_CPUTIME_ID, &time_start);
__m256 AVXout;
__m256 AVXtaps;
__m256 AVXin;
{
boost::mutex::scoped_lock lock(fwd->taps_mutex);
for (i = 0; i < sizeIn - 2*fwd->n_taps; i += 8) {
AVXout = _mm256_setr_ps(0,0,0,0,0,0,0,0);
for (int j = 0; j < fwd->n_taps; j++) {
if ((uintptr_t)(&in[i+2*j]) % 32 == 0) {
AVXin = _mm256_load_ps(&in[i+2*j]); //faster when aligned
}
else {
AVXin = _mm256_loadu_ps(&in[i+2*j]);
}
AVXtaps = _mm256_load1_ps(fwd->taps[j]);
AVXout = _mm256_add_ps(AVXout, _mm256_mul_ps(AVXin, AVXtaps));
}
_mm256_store_ps(&out[i], AVXout);
}
for (; i < sizeIn; i++) {
out[i] = 0.0;
for (int j = 0; i+2*j < sizeIn; j++) {
out[i] += in[i+2*j] * fwd->taps[j];
}
}
}
clock_gettime(CLOCK_THREAD_CPUTIME_ID, &time_end);
#elif __SSE__
// The SSE accelerated version cannot work on the complex values,
// it is necessary to do the convolution on the real and imaginary
// parts separately. Thankfully, the taps are real, simplifying the
// procedure.
const float* in = reinterpret_cast<const float*>(dataIn->getData());
float* out = reinterpret_cast<float*>(dataOut->getData());
size_t sizeIn = dataIn->getLength() / sizeof(float);
if ((uintptr_t)(&out[0]) % 16 != 0) {
fprintf(stderr, "FIRFilterWorker: out not aligned %p ", out);
throw std::runtime_error("FIRFilterWorker: out not aligned");
}
clock_gettime(CLOCK_THREAD_CPUTIME_ID, &time_start);
__m128 SSEout;
__m128 SSEtaps;
__m128 SSEin;
{
boost::mutex::scoped_lock lock(fwd->taps_mutex);
for (i = 0; i < sizeIn - 2*fwd->n_taps; i += 4) {
SSEout = _mm_setr_ps(0,0,0,0);
for (int j = 0; j < fwd->n_taps; j++) {
if ((uintptr_t)(&in[i+2*j]) % 16 == 0) {
SSEin = _mm_load_ps(&in[i+2*j]); //faster when aligned
}
else {
SSEin = _mm_loadu_ps(&in[i+2*j]);
}
SSEtaps = _mm_load1_ps(&fwd->taps[j]);
SSEout = _mm_add_ps(SSEout, _mm_mul_ps(SSEin, SSEtaps));
}
_mm_store_ps(&out[i], SSEout);
}
for (; i < sizeIn; i++) {
out[i] = 0.0;
for (int j = 0; i+2*j < sizeIn; j++) {
out[i] += in[i+2*j] * fwd->taps[j];
}
}
}
clock_gettime(CLOCK_THREAD_CPUTIME_ID, &time_end);
#else
// No SSE ? Loop unrolling should make this faster. As for the SSE,
// the real and imaginary parts are calculated separately.
const float* in = reinterpret_cast<const float*>(dataIn->getData());
float* out = reinterpret_cast<float*>(dataOut->getData());
size_t sizeIn = dataIn->getLength() / sizeof(float);
clock_gettime(CLOCK_THREAD_CPUTIME_ID, &time_start);
{
boost::mutex::scoped_lock lock(fwd->taps_mutex);
// Convolve by aligning both frame and taps at zero.
for (i = 0; i < sizeIn - 2*fwd->n_taps; i += 4) {
out[i] = 0.0;
out[i+1] = 0.0;
out[i+2] = 0.0;
out[i+3] = 0.0;
for (int j = 0; j < fwd->n_taps; j++) {
out[i] += in[i + 2*j] * fwd->taps[j];
out[i+1] += in[i+1 + 2*j] * fwd->taps[j];
out[i+2] += in[i+2 + 2*j] * fwd->taps[j];
out[i+3] += in[i+3 + 2*j] * fwd->taps[j];
}
}
// At the end of the frame, we cut the convolution off.
// The beginning of the next frame starts with a NULL symbol
// anyway.
for (; i < sizeIn; i++) {
out[i] = 0.0;
for (int j = 0; i+2*j < sizeIn; j++) {
out[i] += in[i+2*j] * fwd->taps[j];
}
}
}
clock_gettime(CLOCK_THREAD_CPUTIME_ID, &time_end);
#endif
// The following implementations are for debugging only.
#if 0
// Same thing as above, without loop unrolling. For debugging.
const float* in = reinterpret_cast<const float*>(dataIn->getData());
float* out = reinterpret_cast<float*>(dataOut->getData());
size_t sizeIn = dataIn->getLength() / sizeof(float);
for (i = 0; i < sizeIn - 2*fwd->n_taps; i += 1) {
out[i] = 0.0;
for (int j = 0; j < fwd->n_taps; j++) {
out[i] += in[i+2*j] * fwd->taps[j];
}
}
for (; i < sizeIn; i++) {
out[i] = 0.0;
for (int j = 0; i+2*j < sizeIn; j++) {
out[i] += in[i+2*j] * fwd->taps[j];
}
}
#elif 0
// An unrolled loop, but this time, the input data is cast to complex float.
// Makes indices more natural. For debugging.
const complexf* in = reinterpret_cast<const complexf*>(dataIn->getData());
complexf* out = reinterpret_cast<complexf*>(dataOut->getData());
size_t sizeIn = dataIn->getLength() / sizeof(complexf);
for (i = 0; i < sizeIn - fwd->n_taps; i += 4) {
out[i] = 0.0;
out[i+1] = 0.0;
out[i+2] = 0.0;
out[i+3] = 0.0;
for (int j = 0; j < fwd->n_taps; j++) {
out[i] += in[i+j ] * fwd->taps[j];
out[i+1] += in[i+1+j] * fwd->taps[j];
out[i+2] += in[i+2+j] * fwd->taps[j];
out[i+3] += in[i+3+j] * fwd->taps[j];
}
}
for (; i < sizeIn; i++) {
out[i] = 0.0;
for (int j = 0; j+i < sizeIn; j++) {
out[i] += in[i+j] * fwd->taps[j];
}
}
#elif 0
// Simple implementation. Slow. For debugging.
const complexf* in = reinterpret_cast<const complexf*>(dataIn->getData());
complexf* out = reinterpret_cast<complexf*>(dataOut->getData());
size_t sizeIn = dataIn->getLength() / sizeof(complexf);
for (i = 0; i < sizeIn - fwd->n_taps; i += 1) {
out[i] = 0.0;
for (int j = 0; j < fwd->n_taps; j++) {
out[i] += in[i+j ] * fwd->taps[j];
}
}
for (; i < sizeIn; i++) {
out[i] = 0.0;
for (int j = 0; j+i < sizeIn; j++) {
out[i] += in[i+j] * fwd->taps[j];
}
}
#endif
calculationTime += (time_end.tv_sec - time_start.tv_sec) * 1000000000L +
time_end.tv_nsec - time_start.tv_nsec;
fwd->output_queue.push(dataOut);
}
}
FIRFilter::FIRFilter(std::string taps_file) :
ModCodec(ModFormat(sizeof(complexf)), ModFormat(sizeof(complexf))),
RemoteControllable("firfilter"),
myTapsFile(taps_file)
{
PDEBUG("FIRFilter::FIRFilter(%s) @ %p\n",
taps_file.c_str(), this);
RC_ADD_PARAMETER(ntaps, "(Read-only) number of filter taps.");
RC_ADD_PARAMETER(tapsfile, "Filename containing filter taps. When written to, the new file gets automatically loaded.");
number_of_runs = 0;
firwd.taps = new float[0];
load_filter_taps();
#if __AVX__
fprintf(stderr, "FIRFilter: WARNING: using experimental AVX code !\n");
#endif
PDEBUG("FIRFilter: Starting worker\n" );
worker.start(&firwd);
}
void
FIRFilter::load_filter_taps()
{
std::ifstream taps_fstream(myTapsFile.c_str());
if(!taps_fstream) {
fprintf(stderr, "FIRFilter: file %s could not be opened !\n", myTapsFile.c_str());
throw std::runtime_error("FIRFilter: Could not open file with taps! ");
}
int n_taps;
taps_fstream >> n_taps;
if (n_taps <= 0) {
fprintf(stderr, "FIRFilter: warning: taps file has invalid format\n");
throw std::runtime_error("FIRFilter: taps file has invalid format.");
}
if (n_taps > 100) {
fprintf(stderr, "FIRFilter: warning: taps file has more than 100 taps\n");
}
myNtaps = n_taps;
fprintf(stderr, "FIRFilter: Reading %d taps...\n", myNtaps);
myFilter = new float[myNtaps];
int n;
for (n = 0; n < n_taps; n++) {
taps_fstream >> myFilter[n];
PDEBUG("FIRFilter: tap: %f\n", myFilter[n] );
if (taps_fstream.eof()) {
fprintf(stderr, "FIRFilter: file %s should contains %d taps, but EOF reached "\
"after %d taps !\n", myTapsFile.c_str(), n_taps, n);
delete[] myFilter;
throw std::runtime_error("FIRFilter: filtertaps file invalid ! ");
}
}
{
boost::mutex::scoped_lock lock(firwd.taps_mutex);
delete[] firwd.taps;
firwd.taps = myFilter;
firwd.n_taps = myNtaps;
}
}
FIRFilter::~FIRFilter()
{
PDEBUG("FIRFilter::~FIRFilter() @ %p\n", this);
worker.stop();
if (myFilter != NULL) {
delete[] myFilter;
}
}
int FIRFilter::process(Buffer* const dataIn, Buffer* dataOut)
{
PDEBUG("FIRFilter::process(dataIn: %p, dataOut: %p)\n",
dataIn, dataOut);
// This thread creates the dataIn buffer, and deletes
// the outgoing buffer
boost::shared_ptr<Buffer> inbuffer =
boost::make_shared<Buffer>(dataIn->getLength(), dataIn->getData());
firwd.input_queue.push(inbuffer);
if (number_of_runs > 2) {
boost::shared_ptr<Buffer> outbuffer;
firwd.output_queue.wait_and_pop(outbuffer);
dataOut->setData(outbuffer->getData(), outbuffer->getLength());
}
else {
dataOut->setLength(dataIn->getLength());
memset(dataOut->getData(), 0, dataOut->getLength());
number_of_runs++;
}
return dataOut->getLength();
}
void FIRFilter::set_parameter(const string& parameter, const string& value)
{
stringstream ss(value);
ss.exceptions ( stringstream::failbit | stringstream::badbit );
if (parameter == "ntaps") {
throw ParameterError("Parameter 'ntaps' is read-only");
}
else if (parameter == "tapsfile") {
myTapsFile = value;
try {
load_filter_taps();
}
catch (std::runtime_error &e) {
throw ParameterError(e.what());
}
}
else {
stringstream ss;
ss << "Parameter '" << parameter << "' is not exported by controllable " << get_rc_name();
throw ParameterError(ss.str());
}
}
const string FIRFilter::get_parameter(const string& parameter) const
{
stringstream ss;
if (parameter == "ntaps") {
ss << myNtaps;
}
else if (parameter == "tapsfile") {
ss << myTapsFile;
}
else {
ss << "Parameter '" << parameter << "' is not exported by controllable " << get_rc_name();
throw ParameterError(ss.str());
}
return ss.str();
}
|