From a252a2f3d8ff70b9628d097dfcd99ac9935dbe33 Mon Sep 17 00:00:00 2001 From: Martin Braun Date: Thu, 2 Jul 2020 15:19:34 +0200 Subject: mpm: Fix various Pylint issues No functional changes. Fixes for things that PyLint complains about, but are safe to change anyway, as well as a minor improvement to a docstring that referenced non-existant args. This touches files that are mpm.conf-related. --- mpm/python/usrp_mpm/periph_manager/e320_periphs.py | 1 - mpm/python/usrp_mpm/periph_manager/n3xx.py | 7 ++----- 2 files changed, 2 insertions(+), 6 deletions(-) (limited to 'mpm/python/usrp_mpm/periph_manager') diff --git a/mpm/python/usrp_mpm/periph_manager/e320_periphs.py b/mpm/python/usrp_mpm/periph_manager/e320_periphs.py index 626ee602a..0bda54775 100644 --- a/mpm/python/usrp_mpm/periph_manager/e320_periphs.py +++ b/mpm/python/usrp_mpm/periph_manager/e320_periphs.py @@ -353,4 +353,3 @@ class MboardRegsControl(MboardRegsCommon): else: self.log.trace("RX RF PLL locked") return locked - diff --git a/mpm/python/usrp_mpm/periph_manager/n3xx.py b/mpm/python/usrp_mpm/periph_manager/n3xx.py index b87edfac0..ea6274af8 100644 --- a/mpm/python/usrp_mpm/periph_manager/n3xx.py +++ b/mpm/python/usrp_mpm/periph_manager/n3xx.py @@ -192,9 +192,6 @@ class n3xx(ZynqComponents, PeriphManagerBase): Lists device tree overlays that need to be applied before this class can be used. List of strings. Are applied in order. - - eeprom_md -- Dictionary of info read out from the mboard EEPROM - device_args -- Arbitrary dictionary of info, typically user-defined """ # In the N3xx case, we name the dtbo file the same as the product. # N310 -> n310.dtbo, N300 -> n300.dtbo and so on. @@ -584,8 +581,8 @@ class n3xx(ZynqComponents, PeriphManagerBase): def set_time_source(self, time_source): " Set a time source " clock_source = self._clock_source - assert clock_source != None - assert time_source != None + assert clock_source is not None + assert time_source is not None if (clock_source, time_source) not in self.valid_sync_sources: if time_source == 'sfp0': clock_source = 'internal' -- cgit v1.2.3