From 3ad6dc8a699d302a1f31b101a0b94ada8e343bc0 Mon Sep 17 00:00:00 2001 From: Martin Braun Date: Fri, 28 Jan 2022 11:55:14 +0100 Subject: mpm: eeprom: Improve E320 and N3x0 EEPROM code/comments - Fix some Pylint warnings in eeprom.py - Improve comments in n3xx.py and e320.py regarding rev_compat values in EEPROM --- mpm/python/usrp_mpm/periph_manager/e320.py | 5 +++++ mpm/python/usrp_mpm/periph_manager/n3xx.py | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) (limited to 'mpm/python/usrp_mpm/periph_manager') diff --git a/mpm/python/usrp_mpm/periph_manager/e320.py b/mpm/python/usrp_mpm/periph_manager/e320.py index fe7debd62..b191285e8 100644 --- a/mpm/python/usrp_mpm/periph_manager/e320.py +++ b/mpm/python/usrp_mpm/periph_manager/e320.py @@ -87,6 +87,11 @@ class e320(ZynqComponents, PeriphManagerBase): mboard_info = {"type": "e3xx", "product": "e320" } + # This is the latest HW revision that his version of MPM is aware of. This + # version of MPM will be able to run with any hardware which has a rev_compat + # field that is equal or less than this value. + # Note: If the hardware is revved in a non-compatible way, eeprom-init.c + # must also be updated (derive_rev_compat). mboard_max_rev = 4 # rev E mboard_sensor_callback_map = { 'ref_locked': 'get_ref_lock_sensor', diff --git a/mpm/python/usrp_mpm/periph_manager/n3xx.py b/mpm/python/usrp_mpm/periph_manager/n3xx.py index b780f2011..09386106d 100644 --- a/mpm/python/usrp_mpm/periph_manager/n3xx.py +++ b/mpm/python/usrp_mpm/periph_manager/n3xx.py @@ -126,7 +126,12 @@ class n3xx(ZynqComponents, PeriphManagerBase): mboard_eeprom_offset = 0 mboard_eeprom_max_len = 256 mboard_info = {"type": "n3xx"} - mboard_max_rev = 10 # latest HW revision that this version of MPM is aware of + # This is the latest HW revision that his version of MPM is aware of. This + # version of MPM will be able to run with any hardware which has a rev_compat + # field that is equal or less than this value. + # Note: If the hardware is revved in a non-compatible way, eeprom-init.c + # must also be updated (derive_rev_compat). + mboard_max_rev = 10 mboard_sensor_callback_map = { 'ref_locked': 'get_ref_lock_sensor', 'gps_locked': 'get_gps_lock_sensor', -- cgit v1.2.3