From 0d273bfe0c5c77160d5d5fdbfc9b2a8c9f71a5c2 Mon Sep 17 00:00:00 2001 From: Martin Braun Date: Thu, 20 Aug 2020 10:30:26 +0200 Subject: tests: fbs test: Fix issues around missing git - update_fbs.py would use git directly, instead of the requested git executable - There are other corner cases for the git executable detection, which are now all captured under a more general exception type Credit to Christopher Friedt for pointing out the original issue. --- host/tests/verify_fbs_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'host/tests') diff --git a/host/tests/verify_fbs_test.py b/host/tests/verify_fbs_test.py index c3ee763e4..261037c4f 100644 --- a/host/tests/verify_fbs_test.py +++ b/host/tests/verify_fbs_test.py @@ -26,7 +26,8 @@ class VerifyFBSTest(unittest.TestCase): spec.loader.exec_module(update_fbs) try: git_exe = update_fbs.find_executable("git") - except RuntimeError: + # pylint: disable=broad-except + except Exception: # No git, no test. We pass b/c git is not a UHD dependency. return sys.argv.append('--verify') -- cgit v1.2.3