From 064634b05c9e94ef11b9a8779d389b97e46fb3de Mon Sep 17 00:00:00 2001 From: Ben Hilburn Date: Mon, 9 Feb 2015 16:25:45 -0800 Subject: uhd::paths: Fixed empty string in error message --- host/lib/utils/paths.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'host/lib') diff --git a/host/lib/utils/paths.cpp b/host/lib/utils/paths.cpp index e304555bd..4a95431b8 100644 --- a/host/lib/utils/paths.cpp +++ b/host/lib/utils/paths.cpp @@ -348,6 +348,7 @@ std::string uhd::find_image_path(const std::string &image_name, const std::strin } /* If we made it this far, then we didn't find anything. */ + images_dir = ""; throw uhd::io_error("Could not find path for image: " + image_name + "\n\n" + "Using images directory: " + images_dir -- cgit v1.2.3 From b10c9dd446f0b0567e6b16add0fc8004d465d76e Mon Sep 17 00:00:00 2001 From: Ben Hilburn Date: Tue, 10 Feb 2015 15:56:50 -0800 Subject: uhd::paths - fixing `get_app_path` to use correct `get_env_var` function Also added new enviornment variable, "UHDCALIBPATH", so that users can use something other than system-required environment paths. --- host/lib/utils/paths.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'host/lib') diff --git a/host/lib/utils/paths.cpp b/host/lib/utils/paths.cpp index e304555bd..235c2607d 100644 --- a/host/lib/utils/paths.cpp +++ b/host/lib/utils/paths.cpp @@ -173,11 +173,14 @@ std::string uhd::get_tmp_path(void){ } std::string uhd::get_app_path(void){ - const char *appdata_path = std::getenv("APPDATA"); - if (appdata_path != NULL) return appdata_path; + const std::string uhdcalib_path = get_env_var("UHDCALIBPATH"); + if (not uhdcalib_path.empty()) return uhdcalib_path; - const char *home_path = std::getenv("HOME"); - if (home_path != NULL) return home_path; + const std::string appdata_path = get_env_var("APPDATA"); + if (not appdata_path.empty()) return appdata_path; + + const std::string home_path = get_env_var("HOME"); + if (not home_path.empty()) return home_path; return uhd::get_tmp_path(); } -- cgit v1.2.3 From ac958d47e8c7c4e0ee6a010d3e5a592d392e9206 Mon Sep 17 00:00:00 2001 From: Jon Kiser Date: Mon, 2 Feb 2015 11:49:09 -0800 Subject: ad936x: removing gain_offset from rx set_gain --- host/lib/usrp/common/ad9361_ctrl.hpp | 2 +- .../usrp/common/ad9361_driver/ad9361_device.cpp | 25 +++++----------------- 2 files changed, 6 insertions(+), 21 deletions(-) (limited to 'host/lib') diff --git a/host/lib/usrp/common/ad9361_ctrl.hpp b/host/lib/usrp/common/ad9361_ctrl.hpp index 16e1d23eb..c5718302f 100644 --- a/host/lib/usrp/common/ad9361_ctrl.hpp +++ b/host/lib/usrp/common/ad9361_ctrl.hpp @@ -52,7 +52,7 @@ public: static uhd::meta_range_t get_gain_range(const std::string &which) { if(which[0] == 'R') { - return uhd::meta_range_t(0.0, 73.0, 1.0); + return uhd::meta_range_t(0.0, 76.0, 1.0); } else { return uhd::meta_range_t(0.0, 89.75, 0.25); } diff --git a/host/lib/usrp/common/ad9361_driver/ad9361_device.cpp b/host/lib/usrp/common/ad9361_driver/ad9361_device.cpp index 97b214d7d..d3e53c80f 100644 --- a/host/lib/usrp/common/ad9361_driver/ad9361_device.cpp +++ b/host/lib/usrp/common/ad9361_driver/ad9361_device.cpp @@ -1854,31 +1854,16 @@ double ad9361_device_t::tune(direction_t direction, const double value) /* Set the gain of RX1, RX2, TX1, or TX2. * - * Note that the 'value' passed to this function is the actual gain value, - * _not_ the gain index. This is the opposite of the eval software's GUI! - * Also note that the RX chains are done in terms of gain, and the TX chains - * are done in terms of attenuation. */ + * Note that the 'value' passed to this function is the gain index + * for RX. Also note that the RX chains are done in terms of gain, and + * the TX chains are done in terms of attenuation. */ double ad9361_device_t::set_gain(direction_t direction, chain_t chain, const double value) { boost::lock_guard lock(_mutex); if (direction == RX) { - /* Indexing the gain tables requires an offset from the requested - * amount of total gain in dB: - * < 1300MHz: dB + 5 - * >= 1300MHz and < 4000MHz: dB + 3 - * >= 4000MHz and <= 6000MHz: dB + 14 - */ - int gain_offset = 0; - if (_rx_freq < 1300e6) { - gain_offset = 5; - } else if (_rx_freq < 4000e6) { - gain_offset = 3; - } else { - gain_offset = 14; - } - int gain_index = static_cast(value + gain_offset); + int gain_index = static_cast(value); /* Clip the gain values to the proper min/max gain values. */ if (gain_index > 76) @@ -1894,7 +1879,7 @@ double ad9361_device_t::set_gain(direction_t direction, chain_t chain, const dou _io_iface->poke8(0x10c, gain_index); } - return gain_index - gain_offset; + return gain_index; } else { /* Setting the below bits causes a change in the TX attenuation word * to immediately take effect. */ -- cgit v1.2.3 From 08267a8c0264e08fe6631ce2ede0ec2c2933463f Mon Sep 17 00:00:00 2001 From: Ben Hilburn Date: Wed, 11 Feb 2015 16:28:35 -0800 Subject: Creating the $UHD_CONFIG_DIR env var, here used for custom cal data storage. This is a renaming of the previously created $UHDCALIBPATH. --- host/docs/calibration.dox | 18 +++++++++++++----- host/lib/utils/paths.cpp | 2 +- 2 files changed, 14 insertions(+), 6 deletions(-) (limited to 'host/lib') diff --git a/host/docs/calibration.dox b/host/docs/calibration.dox index 603ae22e4..eecb7af5c 100644 --- a/host/docs/calibration.dox +++ b/host/docs/calibration.dox @@ -57,15 +57,23 @@ daughterboard's EEPROM: : \subsection calibration_data Calibration Data -Calibration files are stored in the user's home/application directory. -They can easily be moved from machine to another by copying the "cal" -directory. Re-running a calibration utility will replace the existing -calibration file. The old calibration file will be renamed so it may be -recovered by the user. +By default, calibration files are stored in the user's home/application +directory: - **Linux:** `${HOME}/.uhd/cal/` - **Windows:** `%APPDATA%\.uhd\cal\` +If you would like to specify a custom directory, you can do so with the +`$UHD_CONFIG_DIR` environment variable: + +- **Custom (any OS):** `${UHD_CONFIG_DIR}/.uhd/cal/` + +Calibration files can easily be moved from one machine to another by copying the +"cal" directory. Re-running a calibration utility will replace the existing +calibration file. The old calibration file will be renamed so it may be +recovered by the user. + + \subsection ignore_cal_file Ignoring Calibration Files At runtime, the user can choose to ignore a daughterboard's calibration file by adding "ignore-cal-file" to the arguments. With the UHD API, it can be done as follows: diff --git a/host/lib/utils/paths.cpp b/host/lib/utils/paths.cpp index 235c2607d..88bd25fbd 100644 --- a/host/lib/utils/paths.cpp +++ b/host/lib/utils/paths.cpp @@ -173,7 +173,7 @@ std::string uhd::get_tmp_path(void){ } std::string uhd::get_app_path(void){ - const std::string uhdcalib_path = get_env_var("UHDCALIBPATH"); + const std::string uhdcalib_path = get_env_var("UHD_CONFIG_DIR"); if (not uhdcalib_path.empty()) return uhdcalib_path; const std::string appdata_path = get_env_var("APPDATA"); -- cgit v1.2.3