From 107a49c0c236940da7d3bd0f57da4bc1e2a34cb4 Mon Sep 17 00:00:00 2001 From: Martin Braun Date: Fri, 8 Jan 2021 09:33:36 +0100 Subject: host: Update code base using clang-tidy The checks from the new clang-tidy file are applied to the source tree using: $ find . -name "*.cpp" | sort -u | xargs \ --max-procs 8 --max-args 1 clang-tidy --format-style=file \ --fix -p /path/to/compile_commands.json --- host/lib/utils/gain_group.cpp | 12 ++++++------ host/lib/utils/tasks.cpp | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'host/lib/utils') diff --git a/host/lib/utils/gain_group.cpp b/host/lib/utils/gain_group.cpp index 5544afb0c..e66692570 100644 --- a/host/lib/utils/gain_group.cpp +++ b/host/lib/utils/gain_group.cpp @@ -63,7 +63,7 @@ public: /*NOP*/ } - gain_range_t get_range(const std::string& name) + gain_range_t get_range(const std::string& name) override { if (not name.empty()) return _name_to_fcns.get(name).get_range(); @@ -83,7 +83,7 @@ public: return gain_range_t(overall_min, overall_max, overall_step); } - double get_value(const std::string& name) + double get_value(const std::string& name) override { if (not name.empty()) return _name_to_fcns.get(name).get_value(); @@ -95,13 +95,13 @@ public: return overall_gain; } - void set_value(double gain, const std::string& name) + void set_value(double gain, const std::string& name) override { if (not name.empty()) return _name_to_fcns.get(name).set_value(gain); std::vector all_fcns = get_all_fcns(); - if (all_fcns.size() == 0) + if (all_fcns.empty()) return; // nothing to set! // get the max step size among the gains @@ -157,13 +157,13 @@ public: } } - const std::vector get_names(void) + const std::vector get_names(void) override { return _name_to_fcns.keys(); } void register_fcns( - const std::string& name, const gain_fcns_t& gain_fcns, size_t priority) + const std::string& name, const gain_fcns_t& gain_fcns, size_t priority) override { if (name.empty() or _name_to_fcns.has_key(name)) { // ensure the name name is unique and non-empty diff --git a/host/lib/utils/tasks.cpp b/host/lib/utils/tasks.cpp index ce6e1716c..0eddd2488 100644 --- a/host/lib/utils/tasks.cpp +++ b/host/lib/utils/tasks.cpp @@ -91,7 +91,7 @@ public: _spawn_barrier.wait(); } - ~msg_task_impl(void) + ~msg_task_impl(void) override { _running = false; _thread_group.interrupt_all(); @@ -104,7 +104,7 @@ public: * stranded messages here. This might happen during shutdown when dtors are called. * See also: comments in b200_io_impl->handle_async_task */ - msg_payload_t get_msg_from_dump_queue(uint32_t sid) + msg_payload_t get_msg_from_dump_queue(uint32_t sid) override { boost::mutex::scoped_lock lock(_mutex); msg_payload_t b; -- cgit v1.2.3