From b6119e581e6ea9273b188463dc4529c30db140ba Mon Sep 17 00:00:00 2001 From: Martin Braun Date: Tue, 6 Jul 2021 16:51:55 +0200 Subject: uhd: Replace Boost mutexes and locks with standard options This is a very mechanical task that could almost have been done with sed. Boost versions of mutexes and locks were removed, and replaced with std:: versions. The replacement tables are as follows: == Mutexes == - boost::mutex -> std::mutex - boost::recursive_mutex -> std::recursive_mutex Mutexes behave identically between Boost and std:: and have the same API. == Locks == C++11 has only two types of lock that we use/need in UHD: - std::lock_guard: Identical to boost::lock_guard - std::unique_lock: Identical to boost::unique_lock Boost also has boost::mutex::scoped_lock, which is a typedef for boost::unique_lock<>. However, we often have used scoped_lock where we meant to use lock_guard<>. The name is a bit misleading, "scoped lock" sounding a bit like an RAII mechanism. Therefore, some previous boost::mutex::scoped_lock are now std::lock_guard<>. std::unique_lock is required when doing more than RAII locking (i.e., unlocking, relocking, usage with condition variables, etc.). == Condition Variables == Condition variables were out of the scope of this lock/mutex change, but in UHD, we inconsistently use boost::condition vs. boost::condition_variable. The former is a templated version of the latter, and thus works fine with std::mutex'es. Therefore, some boost::condition_variable where changed to boost::condition. All locks and mutexes use `#include `. The corresponding Boost includes were removed. In some cases, this exposed issues with implicit Boost includes elsewhere. The missing explicit includes were added. --- host/lib/usrp/b200/b200_radio_ctrl_core.cpp | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) (limited to 'host/lib/usrp/b200') diff --git a/host/lib/usrp/b200/b200_radio_ctrl_core.cpp b/host/lib/usrp/b200/b200_radio_ctrl_core.cpp index e885bf1b6..7a730b1fa 100644 --- a/host/lib/usrp/b200/b200_radio_ctrl_core.cpp +++ b/host/lib/usrp/b200/b200_radio_ctrl_core.cpp @@ -14,9 +14,8 @@ #include #include #include -#include -#include #include +#include #include using namespace uhd; @@ -74,14 +73,14 @@ public: ******************************************************************/ void poke32(const wb_addr_type addr, const uint32_t data) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); this->send_pkt(addr / 4, data); this->wait_for_ack(false); } uint32_t peek32(const wb_addr_type addr) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); this->send_pkt(SR_READBACK, addr / 8); const uint64_t res = this->wait_for_ack(true); const uint32_t lo = uint32_t(res & 0xffffffff); @@ -91,7 +90,7 @@ public: uint64_t peek64(const wb_addr_type addr) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); this->send_pkt(SR_READBACK, addr / 8); return this->wait_for_ack(true); } @@ -101,7 +100,7 @@ public: ******************************************************************/ void set_time(const uhd::time_spec_t& time) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); _time = time; _use_time = _time != uhd::time_spec_t(0.0); if (_use_time) @@ -110,13 +109,13 @@ public: uhd::time_spec_t get_time(void) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); return _time; } void set_tick_rate(const double rate) override { - boost::mutex::scoped_lock lock(_mutex); + std::lock_guard lock(_mutex); _tick_rate = rate; } @@ -327,7 +326,7 @@ private: uhd::msg_task::sptr _async_task; const uint32_t _sid; const std::string _name; - boost::mutex _mutex; + std::mutex _mutex; size_t _seq_out; uhd::time_spec_t _time; bool _use_time; -- cgit v1.2.3