From 49e5ef81530684998bc4bc0934590cdaa81190ab Mon Sep 17 00:00:00 2001 From: Martin Braun Date: Fri, 8 Jan 2021 12:25:25 +0100 Subject: lib: Add some virtual dtors Classes where we call delete (implicitly or explicitly) with a virtual inheritance structure need to declare dtors as virtual. This reduces compiler warnings with clang. There are no known bugs (yet) due to this. --- host/lib/include/uhdlib/usrp/common/adf4001_ctrl.hpp | 1 + host/lib/include/uhdlib/usrp/common/io_service_mgr.hpp | 2 ++ host/lib/include/uhdlib/usrp/common/pwr_cal_mgr.hpp | 2 ++ 3 files changed, 5 insertions(+) (limited to 'host/lib/include/uhdlib/usrp/common') diff --git a/host/lib/include/uhdlib/usrp/common/adf4001_ctrl.hpp b/host/lib/include/uhdlib/usrp/common/adf4001_ctrl.hpp index a98238a25..49a69bdbf 100644 --- a/host/lib/include/uhdlib/usrp/common/adf4001_ctrl.hpp +++ b/host/lib/include/uhdlib/usrp/common/adf4001_ctrl.hpp @@ -105,6 +105,7 @@ class adf4001_ctrl { public: adf4001_ctrl(uhd::spi_iface::sptr _spi, int slaveno); + virtual ~adf4001_ctrl() = default; virtual void set_lock_to_ext_ref(bool external); private: diff --git a/host/lib/include/uhdlib/usrp/common/io_service_mgr.hpp b/host/lib/include/uhdlib/usrp/common/io_service_mgr.hpp index 6b2662703..613db9722 100644 --- a/host/lib/include/uhdlib/usrp/common/io_service_mgr.hpp +++ b/host/lib/include/uhdlib/usrp/common/io_service_mgr.hpp @@ -59,6 +59,8 @@ class io_service_mgr public: using sptr = std::shared_ptr; + virtual ~io_service_mgr() = default; + /*! Connects a pair of links to an I/O service * * Call this method to connect a pair of links to an I/O service. For muxed diff --git a/host/lib/include/uhdlib/usrp/common/pwr_cal_mgr.hpp b/host/lib/include/uhdlib/usrp/common/pwr_cal_mgr.hpp index 4d063825b..c24e7718c 100644 --- a/host/lib/include/uhdlib/usrp/common/pwr_cal_mgr.hpp +++ b/host/lib/include/uhdlib/usrp/common/pwr_cal_mgr.hpp @@ -80,6 +80,8 @@ public: get_str_type&& get_key, uhd::gain_group::sptr gain_group); + virtual ~pwr_cal_mgr() = default; + //! Update the gain group (see make()); // // Not thread-safe: Don't call at the same time as set_power() -- cgit v1.2.3