From f22e3c2d475f4579d9fdd0cd533c509a52a47ad1 Mon Sep 17 00:00:00 2001 From: Steven Koo Date: Wed, 6 Jan 2021 11:18:14 -0600 Subject: uhd: revert "Check property type at access..." This change reverts cb9329a681552e6ac6277d16e1627afcbb23e637. The type checking is causing some conversion issues on clang/macos. The type_index checking doesn't work correctly across shared libraries and should not be relied on to verify type, since it can vary from compiler to compiler. Signed-off-by: Steven Koo --- host/include/uhd/property_tree.hpp | 8 +------- host/include/uhd/property_tree.ipp | 6 ++---- 2 files changed, 3 insertions(+), 11 deletions(-) (limited to 'host/include') diff --git a/host/include/uhd/property_tree.hpp b/host/include/uhd/property_tree.hpp index b6acb791f..ebec6a9f8 100644 --- a/host/include/uhd/property_tree.hpp +++ b/host/include/uhd/property_tree.hpp @@ -13,7 +13,6 @@ #include #include #include -#include #include namespace uhd { @@ -253,15 +252,10 @@ private: //! Internal create property with wild-card type virtual void _create(const fs_path& path, - const std::shared_ptr& prop, - std::type_index prop_type) = 0; + const std::shared_ptr& prop) = 0; //! Internal access property with wild-card type virtual std::shared_ptr& _access(const fs_path& path) const = 0; - - //! Internal access property with wild-card type but with type verification - virtual std::shared_ptr& _access_with_type_check( - const fs_path& path, std::type_index expected_prop_type) const = 0; }; } // namespace uhd diff --git a/host/include/uhd/property_tree.ipp b/host/include/uhd/property_tree.ipp index 0fc871091..d0e127c5d 100644 --- a/host/include/uhd/property_tree.ipp +++ b/host/include/uhd/property_tree.ipp @@ -9,7 +9,6 @@ #pragma once #include -#include #include #include @@ -181,8 +180,7 @@ template property& property_tree::create(const fs_path& path, coerce_mode_t coerce_mode) { this->_create(path, - typename std::shared_ptr >(new property_impl(coerce_mode)), - std::type_index(typeid(T))); + typename std::shared_ptr >(new property_impl(coerce_mode))); return this->access(path); } @@ -190,7 +188,7 @@ template property& property_tree::access(const fs_path& path) { return *std::static_pointer_cast >( - this->_access_with_type_check(path, std::type_index(typeid(T)))); + this->_access(path)); } template -- cgit v1.2.3