From 77975d108a704ce18ec52b4ee1764381b1893752 Mon Sep 17 00:00:00 2001 From: Wade Fife Date: Tue, 15 Jun 2021 14:14:14 -0500 Subject: fpga: rfnoc: Fix EOB loss in DUC There were some rare corner cases where the EOB could get lost in the DUC due to the dds_timed logic not always passing it through as it should. This resulted in an underflow error message at the end of transmission. This commit also fixes an issue where part of the last packet used a frequency shift of 0 instead of the requested frequency shift, and an issue where the first few samples of a burst used the wrong frequency shift value. Part of the fix includes adding a TUSER port to dds_sin_cos_lut_only. The TUSER port is built into the IP but was disabled. It is now enabled and set to 1 bit wide. This has a very small effect on resource usage and can be left unconnected when not needed. The dds_freq_tune block was shared by the DUC and DDC. To avoid affecting the DDC, a new version, dds_freq_tune_duc, is being added for the DUC to use that has the necessary fixes. The new dds_wrapper.v is a wrapper for the dds_sin_cos_lut_only IP. This IP has the undesirable behavior that new inputs must be provided to push previous outputs through the IP. This wrapper hides that complexity by adding some logic to ensure all data gets pushed through automatically. This logic uses the TUSER port on the IP. Finally, a testbench for dds_timed was added. --- .../lib/ip/dds_sin_cos_lut_only/dds_sin_cos_lut_only.xci | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'fpga/usrp3/lib/ip') diff --git a/fpga/usrp3/lib/ip/dds_sin_cos_lut_only/dds_sin_cos_lut_only.xci b/fpga/usrp3/lib/ip/dds_sin_cos_lut_only/dds_sin_cos_lut_only.xci index 4220fa7c4..0efbb6929 100644 --- a/fpga/usrp3/lib/ip/dds_sin_cos_lut_only/dds_sin_cos_lut_only.xci +++ b/fpga/usrp3/lib/ip/dds_sin_cos_lut_only/dds_sin_cos_lut_only.xci @@ -35,7 +35,7 @@ 4 0 0 - 0 + 1 100000000 0 @@ -74,7 +74,7 @@ 3 0 0 - 0 + 1 24 1 1 @@ -95,7 +95,7 @@ 1 0 9 - 0 + 2 32 1 0 @@ -117,7 +117,7 @@ 0 0 1 - 0 + 2 24 1 0 @@ -136,7 +136,7 @@ true 12 Configurable - Not_Required + User_Field Not_Required Block_ROM Standard @@ -220,7 +220,7 @@ None false On_Vector - Not_Required + User_Field 1 45 false @@ -256,6 +256,7 @@ + @@ -275,6 +276,7 @@ + -- cgit v1.2.3