From 3798b2cdee43dd31a4ab4737b781a990385471b3 Mon Sep 17 00:00:00 2001 From: Michael West Date: Wed, 14 Aug 2019 17:58:25 -0700 Subject: RFNoC: Re-enable flow ctrl for blocks on same xbar Prior commit disabled flow control for all lossless links, including links between blocks on the same crossbar. That caused packets to jam up the crossbar leading to control packets failing to ACK under certain conditions. This reverts it so flow control is enabled and the crossbar is kept clear. Signed-off-by: Michael West --- host/lib/rfnoc/graph_impl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/host/lib/rfnoc/graph_impl.cpp b/host/lib/rfnoc/graph_impl.cpp index 326e9205d..4c04a0c1e 100644 --- a/host/lib/rfnoc/graph_impl.cpp +++ b/host/lib/rfnoc/graph_impl.cpp @@ -122,7 +122,7 @@ void graph_impl::connect(const block_id_t& src_block, } const bool same_xbar = sid.get_src_addr() == sid.get_dst_addr(); src->configure_flow_control_out(true, /* enable output */ - same_xbar, // Lossless link if on same crossbar + false, // Keep packets from jamming the crossbar buf_size_bytes, 0, /* no packet limit. We need to revisit this at some point. */ src_block_port); -- cgit v1.2.3