Merge branch 'master' into usrp1

6 files changed, 82 insertions, 45 deletions

diff --git a/host/lib/CMakeLists.txt b/host/lib/CMakeLists.txt
index cbb68c725..81845de21 100644
--- a/host/lib/CMakeLists.txt
+++ b/host/lib/CMakeLists.txt
@@ -54,11 +54,13 @@ INCLUDE(${CMAKE_CURRENT_SOURCE_DIR}/utils/CMakeLists.txt)
 # Append to the list of sources for lib uhd
 ########################################################################
 FILE(TO_NATIVE_PATH ${CMAKE_INSTALL_PREFIX}/${PKG_DATA_DIR} LOCAL_PKG_DATA_DIR)
+STRING(REPLACE "\\" "\\\\" LOCAL_PKG_DATA_DIR ${LOCAL_PKG_DATA_DIR})
 MESSAGE(STATUS "Local package data directory: ${LOCAL_PKG_DATA_DIR}")
 
 IF(UNIX)
     #on unix systems, installers will use this directory for the package data
     FILE(TO_NATIVE_PATH /usr/${PKG_DATA_DIR} INSTALLER_PKG_DATA_DIR)
+    STRING(REPLACE "\\" "\\\\" INSTALLER_PKG_DATA_DIR ${INSTALLER_PKG_DATA_DIR})
     MESSAGE(STATUS "Installer package data directory: ${INSTALLER_PKG_DATA_DIR}")
 ENDIF(UNIX)
 
diff --git a/host/lib/usrp/misc_utils.cpp b/host/lib/usrp/misc_utils.cpp
index 46094ba32..a1664d810 100644
--- a/host/lib/usrp/misc_utils.cpp
+++ b/host/lib/usrp/misc_utils.cpp
@@ -25,6 +25,7 @@
 #include <uhd/usrp/codec_props.hpp>
 #include <boost/bind.hpp>
 #include <boost/foreach.hpp>
+#include <boost/format.hpp>
 
 using namespace uhd;
 using namespace uhd::usrp;
@@ -132,43 +133,49 @@ static void verify_xx_subdev_spec(
     wax::obj mboard,
     std::string xx_type
 ){
-    prop_names_t dboard_names = mboard[dboard_names_prop].as<prop_names_t>();
-    UHD_ASSERT_THROW(dboard_names.size() > 0); //well i hope there is a dboard
+    try{
+        prop_names_t dboard_names = mboard[dboard_names_prop].as<prop_names_t>();
+        UHD_ASSERT_THROW(dboard_names.size() > 0); //well i hope there is a dboard
 
-    //the subdevice specification is empty: handle automatic
-    if (subdev_spec.empty()){
-        BOOST_FOREACH(const std::string &db_name, dboard_names){
-            wax::obj dboard = mboard[named_prop_t(dboard_prop, db_name)];
+        //the subdevice specification is empty: handle automatic
+        if (subdev_spec.empty()){
+            BOOST_FOREACH(const std::string &db_name, dboard_names){
+                wax::obj dboard = mboard[named_prop_t(dboard_prop, db_name)];
+
+                //if the dboard slot is populated, take the first subdevice
+                if (dboard[DBOARD_PROP_DBOARD_ID].as<dboard_id_t>() != dboard_id_t::none()){
+                    std::string sd_name = dboard[DBOARD_PROP_SUBDEV_NAMES].as<prop_names_t>().front();
+                    subdev_spec.push_back(subdev_spec_pair_t(db_name, sd_name));
+                    break;
+                }
+            }
 
-            //if the dboard slot is populated, take the first subdevice
-            if (dboard[DBOARD_PROP_DBOARD_ID].as<dboard_id_t>() != dboard_id_t::none()){
+            //didnt find any populated dboards: add the first subdevice
+            if (subdev_spec.empty()){
+                std::string db_name = dboard_names.front();
+                wax::obj dboard = mboard[named_prop_t(dboard_prop, db_name)];
                 std::string sd_name = dboard[DBOARD_PROP_SUBDEV_NAMES].as<prop_names_t>().front();
                 subdev_spec.push_back(subdev_spec_pair_t(db_name, sd_name));
-                break;
             }
         }
 
-        //didnt find any populated dboards: add the first subdevice
-        if (subdev_spec.empty()){
-            std::string db_name = dboard_names.front();
-            wax::obj dboard = mboard[named_prop_t(dboard_prop, db_name)];
-            std::string sd_name = dboard[DBOARD_PROP_SUBDEV_NAMES].as<prop_names_t>().front();
-            subdev_spec.push_back(subdev_spec_pair_t(db_name, sd_name));
-        }
-    }
-
-    //sanity check that the dboard/subdevice names exist for this mboard
-    BOOST_FOREACH(const subdev_spec_pair_t &pair, subdev_spec){
-        //empty db name means select dboard automatically
-        if (pair.db_name.empty()){
-            if (dboard_names.size() != 1) throw std::runtime_error(
-                "A daughterboard name must be provided for multi-slot boards: " + subdev_spec.to_string()
-            );
-            pair.db_name == dboard_names.front();
+        //sanity check that the dboard/subdevice names exist for this mboard
+        BOOST_FOREACH(const subdev_spec_pair_t &pair, subdev_spec){
+            //empty db name means select dboard automatically
+            if (pair.db_name.empty()){
+                if (dboard_names.size() != 1) throw std::runtime_error(
+                    "A daughterboard name must be provided for multi-slot boards: " + subdev_spec.to_string()
+                );
+                pair.db_name == dboard_names.front();
+            }
+            uhd::assert_has(dboard_names, pair.db_name, xx_type + " dboard name");
+            wax::obj dboard = mboard[named_prop_t(dboard_prop, pair.db_name)];
+            uhd::assert_has(dboard[DBOARD_PROP_SUBDEV_NAMES].as<prop_names_t>(), pair.sd_name, xx_type + " subdev name");
         }
-        uhd::assert_has(dboard_names, pair.db_name, xx_type + " dboard name");
-        wax::obj dboard = mboard[named_prop_t(dboard_prop, pair.db_name)];
-        uhd::assert_has(dboard[DBOARD_PROP_SUBDEV_NAMES].as<prop_names_t>(), pair.sd_name, xx_type + " subdev name");
+    }catch(const std::exception &e){
+        throw std::runtime_error(str(boost::format(
+            "Validate %s subdev spec failed: %s\n    %s"
+        ) % xx_type % subdev_spec.to_string() % e.what()));
     }
 }
 
diff --git a/host/lib/usrp/usrp2/dsp_impl.cpp b/host/lib/usrp/usrp2/dsp_impl.cpp
index 347ec38af..6422142ce 100644
--- a/host/lib/usrp/usrp2/dsp_impl.cpp
+++ b/host/lib/usrp/usrp2/dsp_impl.cpp
@@ -31,9 +31,10 @@ static const size_t default_interp = 16;
 /***********************************************************************
  * DDC Helper Methods
  **********************************************************************/
-static unsigned pick_closest_rate(double exact_rate, const std::vector<unsigned> &rates){
+template <typename rate_type>
+static rate_type pick_closest_rate(double exact_rate, const std::vector<rate_type> &rates){
     unsigned closest_match = rates.front();
-    BOOST_FOREACH(unsigned possible_rate, rates){
+    BOOST_FOREACH(rate_type possible_rate, rates){
         if(std::abs(exact_rate - possible_rate) < std::abs(exact_rate - closest_match))
             closest_match = possible_rate;
     }
diff --git a/host/lib/utils/CMakeLists.txt b/host/lib/utils/CMakeLists.txt
index 68945545a..32b679d49 100644
--- a/host/lib/utils/CMakeLists.txt
+++ b/host/lib/utils/CMakeLists.txt
@@ -79,6 +79,7 @@ ENDIF(HAVE_DLFCN_H)
 LIBUHD_APPEND_SOURCES(
     ${CMAKE_SOURCE_DIR}/lib/utils/assert.cpp
     ${CMAKE_SOURCE_DIR}/lib/utils/gain_group.cpp
+    ${CMAKE_SOURCE_DIR}/lib/utils/images.cpp
     ${CMAKE_SOURCE_DIR}/lib/utils/load_modules.cpp
     ${CMAKE_SOURCE_DIR}/lib/utils/paths.cpp
     ${CMAKE_SOURCE_DIR}/lib/utils/props.cpp
diff --git a/host/lib/utils/images.cpp b/host/lib/utils/images.cpp
new file mode 100644
index 000000000..395e542c1
--- /dev/null
+++ b/host/lib/utils/images.cpp
@@ -0,0 +1,40 @@
+//
+// Copyright 2010 Ettus Research LLC
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+//
+
+#include <uhd/utils/images.hpp>
+#include <boost/foreach.hpp>
+#include <boost/filesystem.hpp>
+#include <stdexcept>
+#include <vector>
+
+namespace fs = boost::filesystem;
+
+std::vector<fs::path> get_image_paths(void); //defined in paths.cpp
+
+/***********************************************************************
+ * Find a image in the image paths
+ **********************************************************************/
+std::string uhd::find_image_path(const std::string &image_name){
+    if (fs::exists(image_name)){
+        return fs::system_complete(image_name).file_string();
+    }
+    BOOST_FOREACH(const fs::path &path, get_image_paths()){
+        fs::path image_path = path / image_name;
+        if (fs::exists(image_path)) return image_path.file_string();
+    }
+    throw std::runtime_error("Could not find path for image: " + image_name);
+}
diff --git a/host/lib/utils/paths.cpp b/host/lib/utils/paths.cpp
index 6ad12d3cc..9e9525caf 100644
--- a/host/lib/utils/paths.cpp
+++ b/host/lib/utils/paths.cpp
@@ -85,17 +85,3 @@ std::vector<fs::path> get_module_paths(void){
         paths.push_back(fs::path(INSTALLER_PKG_DATA_DIR) / "modules");
     return paths;
 }
-
-/***********************************************************************
- * Find a image in the image paths
- **********************************************************************/
-std::string find_image_path(const std::string &image_name){
-    if (fs::exists(image_name)){
-        return fs::system_complete(image_name).file_string();
-    }
-    BOOST_FOREACH(const fs::path &path, get_image_paths()){
-        fs::path image_path = path / image_name;
-        if (fs::exists(image_path)) return image_path.file_string();
-    }
-    throw std::runtime_error("Could not find path for image: " + image_name);
-}