diff options
author | Martin Braun <martin.braun@ettus.com> | 2022-05-11 16:04:31 +0200 |
---|---|---|
committer | Aaron Rossetto <aaron.rossetto@ni.com> | 2022-06-10 13:24:04 -0500 |
commit | 03b493c129f06147a6e59ecbade9fa02fc468b06 (patch) | |
tree | f5aaf2e52df64124d4e6509373be6d8cddf93024 | |
parent | c793fbb42a7a2a7ce26c3eb229cea0943f6741ba (diff) | |
download | uhd-03b493c129f06147a6e59ecbade9fa02fc468b06.tar.gz uhd-03b493c129f06147a6e59ecbade9fa02fc468b06.tar.bz2 uhd-03b493c129f06147a6e59ecbade9fa02fc468b06.zip |
n320: Improve comments regarding low band
The N320 code include some constants that were either unused or
incorrect. This clarifies the lowband frequency.
-rw-r--r-- | host/lib/usrp/dboard/rhodium/rhodium_bands.cpp | 6 | ||||
-rw-r--r-- | host/lib/usrp/dboard/rhodium/rhodium_constants.hpp | 4 |
2 files changed, 6 insertions, 4 deletions
diff --git a/host/lib/usrp/dboard/rhodium/rhodium_bands.cpp b/host/lib/usrp/dboard/rhodium/rhodium_bands.cpp index 6c16a7d7f..8a41b4b2b 100644 --- a/host/lib/usrp/dboard/rhodium/rhodium_bands.cpp +++ b/host/lib/usrp/dboard/rhodium/rhodium_bands.cpp @@ -20,6 +20,9 @@ namespace { * The RX path has 8 bands, which we call BAND0 through BAND7. BAND0 is the * lowest frequency band. BAND7 is the highest frequency band. * + * BAND0 is also identical with the "low band", i.e., the frequency range in + * which we shift the signal up to an IF before mixing it back down to DC. + * * The following constants define lower cutoff frequencies for each band. * RHODIUM_RX_BAND1_MIN_FREQ is the cutover frequency for switching from * BAND0 to BAND1, and so on. @@ -45,6 +48,9 @@ constexpr double RHODIUM_RX_BAND7_MIN_FREQ = 4500e6; * The TX path has 8 bands, which we call BAND0 through BAND7. BAND0 is the * lowest frequency band. BAND7 is the highest frequency band. * + * BAND0 is also identical with the "low band", i.e., the frequency range in + * which we shift the signal up to an IF before mixing it back down to DC. + * * The following constants define lower cutoff frequencies for each band. * RHODIUM_TX_BAND1_MIN_FREQ is the cutover frequency for switching from * BAND0 to BAND1, and so on. diff --git a/host/lib/usrp/dboard/rhodium/rhodium_constants.hpp b/host/lib/usrp/dboard/rhodium/rhodium_constants.hpp index 7043c50af..591d02d30 100644 --- a/host/lib/usrp/dboard/rhodium/rhodium_constants.hpp +++ b/host/lib/usrp/dboard/rhodium/rhodium_constants.hpp @@ -27,10 +27,6 @@ static constexpr double RHODIUM_LO1_REF_FREQ = 122.88e6; // Hz static constexpr double RHODIUM_LO_0_9_GHZ_LPF_THRESHOLD_FREQ = 0.975e9; // Hz static constexpr double RHODIUM_LO_2_25_GHZ_LPF_THRESHOLD_FREQ = 2.3e9; // Hz -static constexpr double RHODIUM_LOWBAND_FREQ = 450e6; // Hz -static constexpr double RHODIUM_RX_IF_FREQ = 2.44e9; // Hz -static constexpr double RHODIUM_TX_IF_FREQ = 1.95e9; // Hz - static constexpr double RX_MIN_GAIN = 0.0; static constexpr double RX_MAX_GAIN = 60.0; static constexpr double RX_GAIN_STEP = 1.0; |