diff options
| author | Jonathan Wakely <github@kayari.org> | 2016-05-25 12:49:36 +0100 |
|---|---|---|
| committer | Martin Braun <martin.braun@ettus.com> | 2016-06-07 09:18:54 -0700 |
| commit | d2586e45441a7c72e9aaab1220c655ebd5b24e16 (patch) | |
| tree | 7cbb40c940408179a6f3e4e65f1652a5e457d7c6 | |
| parent | 2004bbdb0298d7a2ce9aa274e4a9bbdd22792567 (diff) | |
| download | uhd-d2586e45441a7c72e9aaab1220c655ebd5b24e16.tar.gz uhd-d2586e45441a7c72e9aaab1220c655ebd5b24e16.tar.bz2 uhd-d2586e45441a7c72e9aaab1220c655ebd5b24e16.zip | |
Fix off-by-one error
There's an off-by-one error in base64_decode_value that results in undefined behaviour when it's passed `'\x7b'`
| -rw-r--r-- | host/lib/usrp/x300/cdecode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/host/lib/usrp/x300/cdecode.c b/host/lib/usrp/x300/cdecode.c index 1d09cbe22..424de6c6b 100644 --- a/host/lib/usrp/x300/cdecode.c +++ b/host/lib/usrp/x300/cdecode.c @@ -11,7 +11,7 @@ int base64_decode_value(char value_in){ static const char decoding[] = {62,-1,-1,-1,63,52,53,54,55,56,57,58,59,60,61,-1,-1,-1,-2,-1,-1,-1,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,-1,-1,-1,-1,-1,-1,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51}; static const char decoding_size = sizeof(decoding); value_in -= 43; - if ((signed char)value_in < 0 || value_in > decoding_size) return -1; + if ((signed char)value_in < 0 || value_in >= decoding_size) return -1; return decoding[(int)value_in]; } |