aboutsummaryrefslogtreecommitdiffstats
path: root/libAACdec/src
Commit message (Collapse)AuthorAgeFilesLines
...
| | | * Unsigned Integer Overflow in InitSegmentBitfield()Fraunhofer IIS FDK2018-12-261-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | Bug: 112662995 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: Ida3b1d49dc35a03a3ff02f6e150cfb55e9e1da11
* | | | Merge "Unsigned Integer Overflow in ↵Jean-Michel Trivi2018-12-261-1/+1
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CAacDecoder_PreRollExtensionPayloadParse()" am: a5cf260931 am: 466adf2a1b am: d07eeb453f Change-Id: Id09444e5b08161f79053c09e42d686551a2b05e5
| * | | Merge "Unsigned Integer Overflow in ↵Jean-Michel Trivi2018-12-261-1/+1
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CAacDecoder_PreRollExtensionPayloadParse()" am: a5cf260931 am: 466adf2a1b Change-Id: I354fe7ee0401e1e154ae42ce9a80672db8a84d08
| | * | Merge "Unsigned Integer Overflow in CAacDecoder_PreRollExtensionPayloadParse()"Jean-Michel Trivi2018-12-271-1/+1
| | |\ \
| | | * | Unsigned Integer Overflow in CAacDecoder_PreRollExtensionPayloadParse()Fraunhofer IIS FDK2018-12-261-1/+1
| | | |/ | | | | | | | | | | | | | | | | | | | | Bug: 112661610 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I96e2c10328fec8fd12f9c752904860b87a72bed2
* | | | Merge "Prevent overflow in usac filters" am: 4053380094 am: eaad782db3Jean-Michel Trivi2018-12-263-10/+9
|\| | | | | | | | | | | | | | | | | | | | | | | am: 18d4dcf255 Change-Id: Id1736dd6af5b656c158896f6d9fcb117231351a4
| * | | Merge "Prevent overflow in usac filters" am: 4053380094Jean-Michel Trivi2018-12-263-10/+9
| |\| | | | | | | | | | | | | | | | | | | | | | am: eaad782db3 Change-Id: I86ee269643f3247138c71ffe88a2a589bfce0357
| | * | Merge "Prevent overflow in usac filters"Jean-Michel Trivi2018-12-273-10/+9
| | |\ \
| | | * | Prevent overflow in usac filtersFraunhofer IIS FDK2018-12-263-10/+9
| | | |/ | | | | | | | | | | | | | | | | | | | | Bug: 112663886 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: Ie7af65a1a556afb141ea5272f70bfea11881ac30
* | | | Merge "Signed Integer Overflow in CLpd_FAC_Acelp2Mdct()" am: 3bb4fe68a6 am: ↵Jean-Michel Trivi2018-12-261-2/+2
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8879fb1fd6 am: 350e4ffea2 Change-Id: I5f6e1d37824f13d791edd8433aac9c591bbfc399
| * | | Merge "Signed Integer Overflow in CLpd_FAC_Acelp2Mdct()" am: 3bb4fe68a6Jean-Michel Trivi2018-12-261-2/+2
| |\| | | | | | | | | | | | | | | | | | | | | | am: 8879fb1fd6 Change-Id: I955c6e7d250ac52986aeb0879dad976dd62d3fab
| | * | Merge "Signed Integer Overflow in CLpd_FAC_Acelp2Mdct()"Jean-Michel Trivi2018-12-271-2/+2
| | |\ \
| | | * | Signed Integer Overflow in CLpd_FAC_Acelp2Mdct()Fraunhofer IIS FDK2018-12-261-2/+2
| | | |/ | | | | | | | | | | | | | | | | | | | | Bug: 112663384 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I5e41f1455ab35060c136abb7f4945fe9a545633c
* | | | Merge "Signed Integer Overflow in E_UTIL_preemph()" am: aea2558c50 am: ↵Jean-Michel Trivi2018-12-264-3/+4
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | b471c2c215 am: f69ca4c614 Change-Id: I78ee4dccc649e0ff2ee4006212795d89c2f8233c
| * | | Merge "Signed Integer Overflow in E_UTIL_preemph()" am: aea2558c50Jean-Michel Trivi2018-12-264-3/+4
| |\| | | | | | | | | | | | | | | | | | | | | | am: b471c2c215 Change-Id: Ib6f14a5f7b33ffb8bce1a9b37531c0872eeceb2e
| | * | Signed Integer Overflow in E_UTIL_preemph()Fraunhofer IIS FDK2018-12-264-3/+4
| | |/ | | | | | | | | | | | | | | | Bug: 112661356 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: Ibc7120aba3d357bfb8d751d80d99a6e0f51473e4
| | * DO NOT MERGE - Merge pie-platform-release (PPRL.181205.001) into masterXin Li2018-12-1110-104/+122
| | |\ | | | | | | | | | | | | | | | | Bug: 120502534 Change-Id: Ie44ac2dc553c40a8a9bd9b42b00a0b01cfa9799a
| | | * Unify audio element loop abort criterion in ER syntaxFraunhofer IIS FDK2018-10-201-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 112891548 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: Iea56cf804cfb9d396810124c718fc91bdff68392 (cherry picked from commit f2bc07da2ed70eb069f3faab1179c4c89792bf3d)
| | | * Always check whether given channel config is supported.Fraunhofer IIS FDK2018-10-201-11/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 112660981 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I169161dd31bc624f2cab6be2b4c6518946ed32ba Merged-In: I169161dd31bc624f2cab6be2b4c6518946ed32ba (cherry picked from commit 25b209f229879a155759d791fe463b8abd283677)
| | | * Prevent bit buffer counter overflow.Fraunhofer IIS FDK2018-09-109-85/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While long-term test we discovered a bit counter overflow in the bit buffer. The bit buffer state was only used by HCR and RVLC tool and can easily be substituted with FDKgetValidBits() call. The following patch completely removes the bit counter and all its obsolete functions. Bug: 112662184 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: Icee0519d26a2aa62367d2dece59cd3d60ffcade7 (cherry picked from commit 15292f7e9620caf9e8df26a62efc2a2891ea822e)
| | | * Break audio element loop in case element_count becomes too large.Fraunhofer IIS FDK2018-09-101-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 112891564 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I35f02d23c0cfd620088291a52d9996a0d5a17199 (cherry picked from commit 3347cfb91a7ecabf5800d72e936f04ce44752bf3)
* | | | Merge "Integer overflow fix in InvMdctTransformLowDelay_fdk()" am: ↵Fraunhofer IIS FDK2018-11-291-3/+5
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | d2be744af2 am: 6e4fe2e06b am: 69e052a1af Change-Id: I17eca04703b565d22659b6a3f8d08e16a818aedc
| * | | Merge "Integer overflow fix in InvMdctTransformLowDelay_fdk()" am: d2be744af2Fraunhofer IIS FDK2018-11-291-3/+5
| |\| | | | | | | | | | | | | | | | | | | | | | am: 6e4fe2e06b Change-Id: Ie017463a9aad54c9b02672c0aa4d1e7f06847427
| | * | Integer overflow fix in InvMdctTransformLowDelay_fdk()Fraunhofer IIS FDK2018-11-281-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 112892194 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I47fdb5b51afd8c588607bf206d4ae3ef4ba1cdb3
| * | | Merge "Add sanity check for allowed LPD sampling rate." am: b8a384b0cdFraunhofer IIS FDK2018-11-281-2/+1
| |\| | | | | | | | | | | | | | | | | | | | | | am: 9cfaf0cd45 Change-Id: I0c9952fe8b16ae2e8d4cb80b30d63ba00e172b09
| | * | Merge "Add sanity check for allowed LPD sampling rate."Treehugger Robot2018-11-281-2/+1
| | |\ \
| | | * | Add sanity check for allowed LPD sampling rate.Fraunhofer IIS FDK2018-11-281-2/+1
| | | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 112662981 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I0702024adc07ed463db795dd48f4efd3de1d7896 Merged-In: Idc9c44a9755b8151d5c7d8107696f43ac592413b
| * | | Merge "Unsigned Integer Overflow in aacDecoder_DecodeFrame()." am: 0a1e3b6ef9Fraunhofer IIS FDK2018-11-271-1/+1
| |\| | | | | | | | | | | | | | | | | | | | | | am: c580437d7c Change-Id: Id8f177954c585644d0535a44560fa3923780a764
| | * | Unsigned Integer Overflow in aacDecoder_DecodeFrame().Fraunhofer IIS FDK2018-11-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 112661742 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I617dd545f9ea0aca5a5e7d214bbc35f089bc355d
| * | | Merge "Fix huffman decoder escape sequence length limitation." am: a4d6ca7b07Fraunhofer IIS FDK2018-11-051-5/+7
| |\| | | | | | | | | | | | | | | | | | | | | | am: ac56cddd1f Change-Id: I422463f26359bef0ad3220c9324ceb26fcd1da14
| | * | Merge "Fix huffman decoder escape sequence length limitation."Treehugger Robot2018-11-051-5/+7
| | |\ \
| | | * | Fix huffman decoder escape sequence length limitation.Fraunhofer IIS FDK2018-11-051-5/+7
| | | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Bug: 112661753 Change-Id: Ib05cc2c065739c27b9720a24f90d0ce4d15bf601 Merged-In: 62623d8d797a3d7314834c59ebc785e738965635
| * | | Merge "Fix call to function sbrDecoder_Header() through pointer to incorrect ↵Jean-Michel Trivi2018-10-121-1/+18
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | function type." am: fb65c0c24b am: 40676e7cba Change-Id: I07d03570c8173eff319c102ce73c51025afdd056
| | * | Fix call to function sbrDecoder_Header() through pointer to incorrect ↵Fraunhofer IIS FDK2018-10-121-1/+18
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | function type. While testing FDK in Android P DP3 x86 64bit emulator we observed a runtime error. The function parameter of the callback didn't use a typeless pointer. Following patch contains a revised sbr decoder callback function with explicit data type cast to be inline with all other callbacks in FDK. Bug: 112662306 Bug: 116075869 Test: on x86: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: Id224de22beaf2eb9631babd838c4c3ceae0a801e Merged-In: Idc9c44a9755b8151d5c7d8107696f43ac592413b
* | | Merge "Unify audio element loop abort criterion in ER syntax" into pi-dev ↵Jean-Michel Trivi2018-10-011-7/+4
|\| | | | | | | | | | | | | | | | | | | | | | | am: 28234107a7 am: 4a6124d231 Change-Id: I12aa62bfe5cc0c2900e6eb0e5427dba5f8a40068
| * | Merge "Unify audio element loop abort criterion in ER syntax" into pi-devJean-Michel Trivi2018-10-011-7/+4
| |\ \
| | * | Unify audio element loop abort criterion in ER syntaxFraunhofer IIS FDK2018-09-271-7/+4
| | |/ | | | | | | | | | | | | | | | Bug: 112891548 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: Iea56cf804cfb9d396810124c718fc91bdff68392
| * | Always check whether given channel config is supported.Fraunhofer IIS FDK2018-09-281-11/+3
| | | | | | | | | | | | | | | | | | | | | Bug: 112660981 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I169161dd31bc624f2cab6be2b4c6518946ed32ba Merged-In: I169161dd31bc624f2cab6be2b4c6518946ed32ba
| * | Merge "Prevent bit buffer counter overflow." into pi-devJean-Michel Trivi2018-09-069-85/+91
| |\ \
| | * | Prevent bit buffer counter overflow.Fraunhofer IIS FDK2018-08-179-85/+91
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While long-term test we discovered a bit counter overflow in the bit buffer. The bit buffer state was only used by HCR and RVLC tool and can easily be substituted with FDKgetValidBits() call. The following patch completely removes the bit counter and all its obsolete functions. Bug: 112662184 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: Icee0519d26a2aa62367d2dece59cd3d60ffcade7
* | | Always check whether given channel config is supported.Fraunhofer IIS FDK2018-09-281-9/+1
| | | | | | | | | | | | | | | | | | Bug: 112660981 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I169161dd31bc624f2cab6be2b4c6518946ed32ba
* | | Merge "Break audio element loop in case element_count becomes too large." ↵Jean-Michel Trivi2018-09-061-1/+24
|\| | | | | | | | | | | | | | | | | | | | | | | into pi-dev am: 4d801e44ba am: a083f27afb Change-Id: I08e08b06d45c782f7cea15b06d370a0ef9920db2
| * | Merge "Break audio element loop in case element_count becomes too large." ↵Jean-Michel Trivi2018-09-061-1/+24
| |\ \ | | | | | | | | | | | | into pi-dev
| | * | Break audio element loop in case element_count becomes too large.Fraunhofer IIS FDK2018-09-051-1/+24
| | |/ | | | | | | | | | | | | | | | Bug: 112891564 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: I35f02d23c0cfd620088291a52d9996a0d5a17199
* | | Merge "Prevent overflow in concealment clipping check" into pi-dev am: ↵Fraunhofer IIS FDK2018-09-061-4/+4
|\| | | | | | | | | | | | | | | | | | | | | | | b3ea08e059 am: 646ead1a65 Change-Id: I76943ca6e6c4541924c34ce6e7da5bf95676abec
| * | Prevent overflow in concealment clipping checkFraunhofer IIS FDK2018-09-051-4/+4
| |/ | | | | | | | | | | Bug: 112890225 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Change-Id: Ie386e4b6fe5cdb38180f673edde8f84c36c7b522
* / FDK sanitization fixesFraunhofer IIS FDK2018-08-1413-101/+125
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 110641440 Bug: 109936783 Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc Prevent bit buffer counter overflow. While long-term test we discovered a bit counter overflow in the bit buffer. The bit buffer state was only used by HCR and RVLC tool and can easily be substituted with FDKgetValidBits() call. The following patch completely removes the bit counter and all its obsolete functions. Change-Id: Icee0519d26a2aa62367d2dece59cd3d60ffcade7 Fix call to function sbrDecoder_Header() through pointer to incorrect function type. While testing FDK in Android P DP3 x86 64bit emulator we observed a runtime error. The function parameter of the callback didn't use a typeless pointer. Following patch contains a revised sbr decoder callback function with explicit data type cast to be inline with all other callbacks in FDK. Change-Id: Id224de22beaf2eb9631babd838c4c3ceae0a801e Fix huffman decoder escape sequence length limitation. Change-Id: Ib05cc2c065739c27b9720a24f90d0ce4d15bf601 Prevent overflow in MPEG-D DRC _setSelectionDataInfo(). Change-Id: I3b90ef7a5168e20766a2574d57d81bb39d2a5fb9 Add sanity check for allowed LPD sampling rate. Change-Id: I0702024adc07ed463db795dd48f4efd3de1d7896 Always check whether given channel config is supported. Change-Id: I169161dd31bc624f2cab6be2b4c6518946ed32ba Unsigned Integer Overflow in aacDecoder_DecodeFrame(). Change-Id: I617dd545f9ea0aca5a5e7d214bbc35f089bc355d Unsigned Integer Overflow in SpatialDecParseSpecificConfigHeader(). Change-Id: I5994a55f993835fa511ff61a337726b3e51aed5d Unsigned Integer Overflows in mpegSurroundDecoder_Parse(). Change-Id: I3714e88d7a9a866297bb2e93571804665a97773f Unsigned Integer Overflow in transportDec_AdjustEndOfAccessUnit(). Change-Id: Ie4924460d30ea4ef76917704ded809d04db78993 Unsigned Integer Overflow in transportDec_readHeader(). Change-Id: I0beedab38175fc57e5bd9eb5700a3850ef2bebf7 UBSAN overflow in FFT An overflow in the fft was observed for certain configurations. The root cause was in the scaling of the fft input data in dct_IV and dst_IV. The following patch revises the scaling in dct and removes the unused arm implementation. Change-Id: Idc9c44a9755b8151d5c7d8107696f43ac592413b
* Fix unsigned integer overflow in aacDecoder_UpdateBitStreamCounters()Fraunhofer IIS FDK2018-05-251-2/+2
| | | | | | Bug: 80314771 Test: play AAC content over 2GB Change-Id: If791305bf95680b945971f9dc5f58495cbf6c8cd
* FDKv2 ubsan patchesFraunhofer IIS FDK2018-05-236-14/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 80053205 Test: see bug for repro with FB "wow" atest DecoderTestAacDrc Fix signed integer overflows in CLpc_SynthesisLattice() Change-Id: Icbddfcc8c5fc73382ae5bf8c2a7703802c688e06 Fix signed integer overflows in imlt Change-Id: I687834fca2f1aab6210ed9862576b4f38fcdeb24 Fix overflow in addLowbandEnergies() Change-Id: Iaa9fdf9deb49c33ec6ca7ed3081c4ddaa920e9aa Concealment fix for audio frames containing acelp components Change-Id: Ibe5e83a6efa75a48f729984a161a76b826878f4e Fix out-of-bounds access in PS concealment Change-Id: I08809a03a40d1feaf00e41278db314d67e1efe88 Fix potential memory leak in setup of qmf domain Change-Id: Id9fc2448354dc7f1b439469128407305efa3def2 Reject channel config 13 Change-Id: Idf5236f6cd054df994e69c9c972c97f6768cf9e5 Fix unsigned integer overflow in configExtension() Change-Id: I8a1668810b85e6237c3892891444ff08f04b019b Fix unsigned integer overflow in CAacDecoder_DecodeFrame() Change-Id: I79678c571690178e6c37680f70a9b94dd3cbc439 Fix unsigned integer overflow in aacDecoder_UpdateBitStreamCounters() Change-Id: I3bff959da9f53fabb18cd0ae6c260e6256194526 Fix unsigned integer overflow in transportDec_readStream() Change-Id: I6a6f9f4acaa32fae0b5de9641f8787bbc7f8286b
* FDK patches: fix overflows in decoder out-of-band configFraunhofer IIS FDK2018-05-091-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 71430241 Bug: 79220129 Test: cts-tradefed run commandAndExit cts-dev -m CtsMediaTestCases -t android.media.cts.DecoderTestXheAac cts-tradefed run commandAndExit cts-dev -m CtsMediaTestCases -t android.media.cts.DecoderTestAacDrc Unsigned Integer Overflows in CDataStreamElement_Read() Change-Id: Ic2f5b3ae111bf984d4d0db664823798957b0a979 Unsigned Integer Overflow in CProgramConfig_ReadHeightExt() Change-Id: Iaebc458bb59504203e604a28ed6d5cecaa875c42 Unsigned Integer Overflow in transportDec_OutOfBandConfig() Change-Id: I24a4b32d736f28c55147f0e2ca06fe5537da19c2 Unsigned Integer Overflows in CDKcrcEndReg() & crcCalc() Change-Id: I6ebbe541a4d3b6bacbd5ace17264972951de7ca8 Unsigned Integer Overflows in ReadPsData() Change-Id: Id36576fe545236860a06f17971494ecd4484c494 Unsigned Integer Overflow in SpatialDecParseSpecificConfig() Change-Id: Ib468f129a951c69776b88468407f008ab4cfd2c7 Unsigned Integer Overflows in _readUniDrcConfigExtension() & _readLoudnessInfoSetExtension() Change-Id: Ibcf7c6a23af49239206ea9301c58adac36e3ceba