diff options
| author | Jean-Michel Trivi <jmtrivi@google.com> | 2018-12-27 01:54:49 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2018-12-27 01:54:49 +0000 |
| commit | 4053380094904317c5c3ef57256abac28fb8f62e (patch) | |
| tree | 3362d8feed35d84e40977a7889c22065cfa481df /libAACdec/src/usacdec_fac.cpp | |
| parent | 3bb4fe68a62afd3c670ad9a8cc79ac100526b561 (diff) | |
| parent | 8166502969e261270d098146c3fcae37d92d3c50 (diff) | |
| download | fdk-aac-4053380094904317c5c3ef57256abac28fb8f62e.tar.gz fdk-aac-4053380094904317c5c3ef57256abac28fb8f62e.tar.bz2 fdk-aac-4053380094904317c5c3ef57256abac28fb8f62e.zip | |
Merge "Prevent overflow in usac filters"
Diffstat (limited to 'libAACdec/src/usacdec_fac.cpp')
| -rw-r--r-- | libAACdec/src/usacdec_fac.cpp | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/libAACdec/src/usacdec_fac.cpp b/libAACdec/src/usacdec_fac.cpp index 25d3119..c10a3fe 100644 --- a/libAACdec/src/usacdec_fac.cpp +++ b/libAACdec/src/usacdec_fac.cpp @@ -191,13 +191,11 @@ static void Syn_filt_zero(const FIXP_LPC a[], const INT a_exp, INT length, L_tmp = (FIXP_DBL)0; for (j = 0; j < fMin(i, M_LP_FILTER_ORDER); j++) { - L_tmp -= fMultDiv2(a[j], x[i - (j + 1)]); + L_tmp -= fMultDiv2(a[j], x[i - (j + 1)]) >> (LP_FILTER_SCALE - 1); } - L_tmp = scaleValue(L_tmp, a_exp + 1); - - x[i] = scaleValueSaturate((x[i] >> 1) + (L_tmp >> 1), - 1); /* Avoid overflow issues and saturate. */ + L_tmp = scaleValue(L_tmp, a_exp + LP_FILTER_SCALE); + x[i] = fAddSaturate(x[i], L_tmp); } } |