aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTreehugger Robot <treehugger-gerrit@google.com>2018-11-05 22:58:33 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2018-11-05 22:58:33 +0000
commita4d6ca7b07569aac07d50f894f3757b58dd2d6eb (patch)
tree1e9b04e0f211d0000c457ca12f8d908571568508
parenta1c3f92674bc881fed06d0dedc88898b06b511c1 (diff)
parentf90be065038d4d4455d85d6ab4b846d6bec320a1 (diff)
downloadfdk-aac-a4d6ca7b07569aac07d50f894f3757b58dd2d6eb.tar.gz
fdk-aac-a4d6ca7b07569aac07d50f894f3757b58dd2d6eb.tar.bz2
fdk-aac-a4d6ca7b07569aac07d50f894f3757b58dd2d6eb.zip
Merge "Fix huffman decoder escape sequence length limitation."
-rw-r--r--libAACdec/src/block.cpp12
1 files changed, 7 insertions, 5 deletions
diff --git a/libAACdec/src/block.cpp b/libAACdec/src/block.cpp
index 7d2a4b9..b3d09a6 100644
--- a/libAACdec/src/block.cpp
+++ b/libAACdec/src/block.cpp
@@ -127,9 +127,11 @@ amm-info@iis.fraunhofer.de
The function reads the escape sequence from the bitstream,
if the absolute value of the quantized coefficient has the
value 16.
- A limitation is implemented to maximal 31 bits to prevent endless loops.
- If it strikes, MAX_QUANTIZED_VALUE + 1 is returned, independent of the sign of
- parameter q.
+ A limitation is implemented to maximal 21 bits according to
+ ISO/IEC 14496-3:2009(E) 4.6.3.3.
+ This limits the escape prefix to a maximum of eight 1's.
+ If more than eight 1's are read, MAX_QUANTIZED_VALUE + 1 is
+ returned, independent of the sign of parameter q.
\return quantized coefficient
*/
@@ -139,11 +141,11 @@ LONG CBlock_GetEscape(HANDLE_FDK_BITSTREAM bs, /*!< pointer to bitstream */
if (fAbs(q) != 16) return (q);
LONG i, off;
- for (i = 4; i < 32; i++) {
+ for (i = 4; i < 13; i++) {
if (FDKreadBit(bs) == 0) break;
}
- if (i == 32) return (MAX_QUANTIZED_VALUE + 1);
+ if (i == 13) return (MAX_QUANTIZED_VALUE + 1);
off = FDKreadBits(bs, i);
i = off + (1 << i);