From c055764200393e4f2ce48daea7d175fd6af26b72 Mon Sep 17 00:00:00 2001
From: "Matthias P. Braendli" <matthias.braendli@mpb.li>
Date: Mon, 1 Jul 2024 13:32:10 +0200
Subject: Common 649e0cb: Replace edi tagpacket callback by AF packet callback

---
 lib/edi/common.cpp | 27 ++++++++++++++-------------
 lib/edi/common.hpp | 10 ++++++----
 2 files changed, 20 insertions(+), 17 deletions(-)

diff --git a/lib/edi/common.cpp b/lib/edi/common.cpp
index c99997a..b314737 100644
--- a/lib/edi/common.cpp
+++ b/lib/edi/common.cpp
@@ -129,10 +129,9 @@ std::string tag_name_to_human_readable(const tag_name_t& name)
     return s;
 }
 
-TagDispatcher::TagDispatcher(
-        std::function<void()>&& af_packet_completed) :
-    m_af_packet_completed(move(af_packet_completed)),
-    m_tagpacket_handler([](const std::vector<uint8_t>& /*ignore*/){})
+TagDispatcher::TagDispatcher(std::function<void()>&& af_packet_completed) :
+    m_af_packet_completed(std::move(af_packet_completed)),
+    m_afpacket_handler([](std::vector<uint8_t>&& /*ignore*/){})
 {
 }
 
@@ -278,7 +277,6 @@ void TagDispatcher::setMaxDelay(int num_af_packets)
 }
 
 
-#define AFPACKET_HEADER_LEN 10 // includes SYNC
 TagDispatcher::decode_result_t TagDispatcher::decode_afpacket(
         const std::vector<uint8_t> &input_data)
 {
@@ -341,25 +339,30 @@ TagDispatcher::decode_result_t TagDispatcher::decode_afpacket(
         return {decode_state_e::Error, AFPACKET_HEADER_LEN + taglength + crclen};
     }
     else {
+        vector<uint8_t> afpacket(AFPACKET_HEADER_LEN + taglength + crclen);
+        copy(input_data.begin(),
+                input_data.begin() + AFPACKET_HEADER_LEN + taglength + crclen,
+                afpacket.begin());
+        m_afpacket_handler(std::move(afpacket));
+
         vector<uint8_t> payload(taglength);
         copy(input_data.begin() + AFPACKET_HEADER_LEN,
                 input_data.begin() + AFPACKET_HEADER_LEN + taglength,
                 payload.begin());
 
-        return {
-            decode_tagpacket(payload) ? decode_state_e::Ok : decode_state_e::Error,
-            AFPACKET_HEADER_LEN + taglength + crclen};
+        auto result = decode_tagpacket(payload) ? decode_state_e::Ok : decode_state_e::Error;
+        return {result, AFPACKET_HEADER_LEN + taglength + crclen};
     }
 }
 
 void TagDispatcher::register_tag(const std::string& tag, tag_handler&& h)
 {
-    m_handlers[tag] = move(h);
+    m_handlers[tag] = std::move(h);
 }
 
-void TagDispatcher::register_tagpacket_handler(tagpacket_handler&& h)
+void TagDispatcher::register_afpacket_handler(afpacket_handler&& h)
 {
-    m_tagpacket_handler = move(h);
+    m_afpacket_handler = std::move(h);
 }
 
 
@@ -428,8 +431,6 @@ bool TagDispatcher::decode_tagpacket(const vector<uint8_t> &payload)
         }
     }
 
-    m_tagpacket_handler(payload);
-
     return success;
 }
 
diff --git a/lib/edi/common.hpp b/lib/edi/common.hpp
index c3e6c40..f273ecf 100644
--- a/lib/edi/common.hpp
+++ b/lib/edi/common.hpp
@@ -32,6 +32,8 @@
 
 namespace EdiDecoder {
 
+constexpr size_t AFPACKET_HEADER_LEN = 10; // includes SYNC
+
 struct frame_timestamp_t {
     uint32_t seconds = 0;
     uint32_t utco = 0;
@@ -133,9 +135,9 @@ class TagDispatcher {
          */
         void register_tag(const std::string& tag, tag_handler&& h);
 
-        /* The complete tagpacket can also be retrieved */
-        using tagpacket_handler = std::function<void(const std::vector<uint8_t>&)>;
-        void register_tagpacket_handler(tagpacket_handler&& h);
+        /* The complete AF packet can also be retrieved */
+        using afpacket_handler = std::function<void(std::vector<uint8_t>&&)>;
+        void register_afpacket_handler(afpacket_handler&& h);
 
         seq_info_t get_seq_info() const {
             return m_last_sequences;
@@ -160,7 +162,7 @@ class TagDispatcher {
         std::vector<uint8_t> m_input_data;
         std::map<std::string, tag_handler> m_handlers;
         std::function<void()> m_af_packet_completed;
-        tagpacket_handler m_tagpacket_handler;
+        afpacket_handler m_afpacket_handler;
 
         std::vector<std::string> m_ignored_tags;
 };
-- 
cgit v1.2.3