summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias P. Braendli <matthias.braendli@mpb.li>2015-01-23 10:58:02 +0100
committerMatthias P. Braendli <matthias.braendli@mpb.li>2015-01-23 10:58:02 +0100
commitdf9aed63a9d30c4778414a28648d41c2eaca50f9 (patch)
tree6d7f4029843f110464b501c8a66d4dfd9c33cb29
parent1b2552c8bbf136808d51aa144f056e433dcb7e4a (diff)
downloaddabmux-df9aed63a9d30c4778414a28648d41c2eaca50f9.tar.gz
dabmux-df9aed63a9d30c4778414a28648d41c2eaca50f9.tar.bz2
dabmux-df9aed63a9d30c4778414a28648d41c2eaca50f9.zip
Security: Telnet only accessible from localhost
-rw-r--r--doc/example.mux2
-rw-r--r--src/RemoteControl.cpp6
2 files changed, 4 insertions, 4 deletions
diff --git a/doc/example.mux b/doc/example.mux
index ec34238..09151e9 100644
--- a/doc/example.mux
+++ b/doc/example.mux
@@ -46,7 +46,7 @@ general {
remotecontrol {
; enable the telnet remote control server on the given port
; This server allows you to read and define parameters that
- ; some features export
+ ; some features export. It is only accessible from localhost.
; Set the port to 0 to disable the server
telnetport 12721
diff --git a/src/RemoteControl.cpp b/src/RemoteControl.cpp
index c8fb0e8..e46bc8d 100644
--- a/src/RemoteControl.cpp
+++ b/src/RemoteControl.cpp
@@ -67,7 +67,8 @@ void RemoteControllerTelnet::process(long)
try {
boost::asio::io_service io_service;
- tcp::acceptor acceptor(io_service, tcp::endpoint(tcp::v4(), m_port));
+ tcp::acceptor acceptor(io_service, tcp::endpoint(
+ boost::asio::ip::address::from_string("127.0.0.1"), m_port) );
while (m_running) {
in_message = "";
@@ -225,8 +226,7 @@ void RemoteControllerTelnet::dispatch_command(tcp::socket& socket, string comman
reply(socket, "Error: Invalid parameter value. ");
}
}
- else
- {
+ else {
reply(socket, "Incorrect parameters for command 'set'");
}
}