From 56e046c3390a15aab4baddb502a490bb4505942a Mon Sep 17 00:00:00 2001 From: "Matthias P. Braendli" Date: Fri, 14 Oct 2022 22:10:30 +0200 Subject: Rework timestamp_refresh Since we have the 'timestamp in the past' warning refresh requests can be lost --- src/output/SDR.cpp | 8 ++++++-- src/output/SDR.h | 2 +- src/output/SDRDevice.h | 7 ++++++- src/output/Soapy.cpp | 2 +- src/output/UHD.cpp | 2 +- 5 files changed, 15 insertions(+), 6 deletions(-) (limited to 'src/output') diff --git a/src/output/SDR.cpp b/src/output/SDR.cpp index 6078fc7..b0c09b6 100644 --- a/src/output/SDR.cpp +++ b/src/output/SDR.cpp @@ -2,7 +2,7 @@ Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Her Majesty the Queen in Right of Canada (Communications Research Center Canada) - Copyright (C) 2018 + Copyright (C) 2022 Matthias P. Braendli, matthias.braendli@mpb.li http://opendigitalradio.org @@ -297,6 +297,10 @@ void SDR::handle_frame(struct FrameData& frame) return; } + if (frame.ts.offset_changed) { + m_device->require_timestamp_refresh(); + } + if (last_tx_time_initialised) { const size_t sizeIn = frame.buf.size() / sizeof(complexf); @@ -325,7 +329,7 @@ void SDR::handle_frame(struct FrameData& frame) tx_second << "+" << (double)tx_pps/16384000.0 << "(" << tx_pps << ")"; - frame.ts.timestamp_refresh = true; + m_device->require_timestamp_refresh(); } } diff --git a/src/output/SDR.h b/src/output/SDR.h index ee89243..33477bf 100644 --- a/src/output/SDR.h +++ b/src/output/SDR.h @@ -2,7 +2,7 @@ Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Her Majesty the Queen in Right of Canada (Communications Research Center Canada) - Copyright (C) 2018 + Copyright (C) 2022 Matthias P. Braendli, matthias.braendli@mpb.li http://opendigitalradio.org diff --git a/src/output/SDRDevice.h b/src/output/SDRDevice.h index bb63f60..b599f5a 100644 --- a/src/output/SDRDevice.h +++ b/src/output/SDRDevice.h @@ -2,7 +2,7 @@ Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Her Majesty the Queen in Right of Canada (Communications Research Center Canada) - Copyright (C) 2019 + Copyright (C) 2022 Matthias P. Braendli, matthias.braendli@mpb.li http://opendigitalradio.org @@ -142,6 +142,11 @@ class SDRDevice { virtual bool is_clk_source_ok(void) const = 0; virtual const char* device_name(void) const = 0; + + virtual void require_timestamp_refresh() { m_require_timestamp_refresh = true; } + + protected: + bool m_require_timestamp_refresh = false; }; } // namespace Output diff --git a/src/output/Soapy.cpp b/src/output/Soapy.cpp index f138e9a..684a9a4 100644 --- a/src/output/Soapy.cpp +++ b/src/output/Soapy.cpp @@ -311,7 +311,7 @@ void Soapy::transmit_frame(const struct FrameData& frame) const bool eob_because_muting = m_conf.muting; const bool end_of_burst = eob_because_muting or ( frame.ts.timestamp_valid and - frame.ts.timestamp_refresh and + m_require_timestamp_refresh and samps_to_send <= mtu ); int flags = 0; diff --git a/src/output/UHD.cpp b/src/output/UHD.cpp index 3cf5aef..ac34ce4 100644 --- a/src/output/UHD.cpp +++ b/src/output/UHD.cpp @@ -348,7 +348,7 @@ void UHD::transmit_frame(const struct FrameData& frame) // EOB and quit the loop afterwards, to avoid an underrun. md_tx.end_of_burst = eob_because_muting or ( frame.ts.timestamp_valid and - frame.ts.timestamp_refresh and + m_require_timestamp_refresh and samps_to_send <= usrp_max_num_samps ); //send a single packet -- cgit v1.2.3