From 60140af509d33cd2179c56388b16746e9d67071a Mon Sep 17 00:00:00 2001 From: "Matthias P. Braendli" Date: Wed, 7 Feb 2018 11:22:11 +0100 Subject: Add some general quality remarks to README --- README.md | 21 +++++++++++++++++++++ src/VLCInput.h | 1 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index ca91a98..b2e96ea 100644 --- a/README.md +++ b/README.md @@ -67,6 +67,27 @@ input on port 9000. DST="tcp://yourserver:9000" BITRATE=64 +General remarks +--------------- + +Avoid using sources that are already encoded with a low bitrate, because +encoder cascading will noticeably reduce audio quality. Best are sources +encoded with a lossless codec (FLAC). Otherwise, try to get MP3 at 320kbps, AAC +at 256kbps or higher bitrates. + +Ideally use a source at the correct sampling rate (32kHz or 48kHz, according to +your encoder configuration). VLC can do resampling, but on some systems selects +the ugly resampler which creates artifacts. Try adding +`-L --audio-resampler=samplerate -L --src-converter-type=0` +to your command line, but enable verbose mode and read the VLC debug output to +check that it enables the libsamplerate resampler, and not the ugly resampler. + +The codecs do not behave well when your source material has peaks that go close +to saturation, especially when you have to resample. When you see little +exclamation marks with the -l option, it's too loud! Reduce the gain at the +source, or use the gain option if that's not possible. + + DAB+ AAC encoder configuration ------------------------------ By default, when not overridden by the --aaclc, --sbr or --ps options, diff --git a/src/VLCInput.h b/src/VLCInput.h index 99ce01d..0eb3e37 100644 --- a/src/VLCInput.h +++ b/src/VLCInput.h @@ -134,7 +134,6 @@ class VLCInput : public InputInterface int getRate() { return m_rate; } - virtual bool fault_detected(void) const override { return m_fault; }; /*! Separator string used when artist/title are written -- cgit v1.2.3