summaryrefslogtreecommitdiffstats
path: root/libSBRdec/src/env_extr.cpp
diff options
context:
space:
mode:
authorMartin Storsjo <martin@martin.st>2013-02-17 02:14:35 +0200
committerMartin Storsjo <martin@martin.st>2013-02-17 02:21:26 +0200
commit8f9f42c1041e877c602e0acd43361d7068c3ce1c (patch)
tree204aeb93b956b00f974039124da7133df1a4162b /libSBRdec/src/env_extr.cpp
parentb966edf7fc05d22e7370d263cbc682efcd361889 (diff)
downloadODR-AudioEnc-8f9f42c1041e877c602e0acd43361d7068c3ce1c.tar.gz
ODR-AudioEnc-8f9f42c1041e877c602e0acd43361d7068c3ce1c.tar.bz2
ODR-AudioEnc-8f9f42c1041e877c602e0acd43361d7068c3ce1c.zip
Don't try to shift more bits than the variable length
Shifting by more than (or equal to) the variable length is undefined in C. This caused the quantized spectrum values to remain unshifted, causing loud beeps in some samples. The exact same change was originally applied in 657456949 (for AOSP) and in 24021f190 (in the separate fdk-aac repo), but was overwritten and silently reverted by the new upstream code drop for Android 4.2 in 381d69840a. After the code drop, I chose not to reapply this change since the crashes that it fixed had been fixed in other ways upstream and I was unable to reproduce them after the new code drop.
Diffstat (limited to 'libSBRdec/src/env_extr.cpp')
0 files changed, 0 insertions, 0 deletions